0001629: Memory issue with upnp.c

ID	Project	Category	View Status	Date Submitted	Last Update
0001629	GNUnet	NAT traversal library	public	2010-12-07 14:41	2011-06-10 11:11

Reporter	mrwiggles	Assigned To	milan
Priority	normal	Severity	minor	Reproducibility	sometimes
Status	closed	Resolution	won't fix

Summary	0001629: Memory issue with upnp.c
Description	There is a line that causes some error messages in upnp.c, already marked by a // BADNESS! comment. It would seem that the line should be something like upnp->iface = GNUNET_strdup(name); On some systems the upnp->iface points to random data at a later point in execution, specifically when UPNP_discover_ is called.
Additional Information	static int process_if (void cls, const char name, int isDefault, const struct sockaddr addr, socklen_t addrlen) { struct GNUNET_NAT_UPNP_Handle upnp = cls; if (addr && GNUNET_NAT_cmp_addr (upnp->addr, addr) == 0) { upnp->iface = name; // BADNESS! return GNUNET_SYSERR; } return GNUNET_OK; }
Tags	No tags attached.

Date Modified	Username	Field	Change
2010-12-07 14:41	mrwiggles	New Issue
2010-12-07 14:41	mrwiggles	Status	new => assigned
2010-12-07 14:41	mrwiggles	Assigned To	=> milan
2011-06-10 11:11	Christian Grothoff	Note Added: 0004352
2011-06-10 11:11	Christian Grothoff	Status	assigned => closed
2011-06-10 11:11	Christian Grothoff	Resolution	open => won't fix

Christian Grothoff 2011-06-10 11:11 manager ~0004352	Based on various discussions, I'm now pretty convinced that this entire upnp code will just go away. So no point in fixing this one.