View Issue Details

IDProjectCategoryView StatusLast Update
0001505GNUnetutil librarypublic2010-07-03 20:55
ReporterChristian Grothoff Assigned ToChristian Grothoff  
PrioritynormalSeverityminorReproducibilityN/A
Status closedResolutionfixed 
Summary0001505: server.c does memmove for alignment even when not required
DescriptionThe code should be changed to see if the struct is already aligned (pointer at a round multiple 8 bytes already; for GNUnet, we should be able to assume that 8-byte alignment is enough); if it is already aligned, we don't need to memmove it to the beginning of the buffer but can process it in-place.

This feature will need to be tested thoroughly (especially to ensure that the resulting 8-byte aligned accesses are as portable as we expect them to be; such portability can only be demonstrated using the buildbot if a testcase actually triggers this).
Additional InformationWould be nice to know if this optimization shows a detectable performance gain using some simple benchmark.
TagsNo tags attached.

Activities

Christian Grothoff

2010-06-22 18:31

manager   ~0004043

Fixed in SVN 11875.

Issue History

Date Modified Username Field Change
2009-11-10 14:53 Christian Grothoff New Issue
2009-11-10 14:54 Christian Grothoff Assigned To => user457
2009-11-10 14:54 Christian Grothoff Status new => assigned
2009-12-24 22:37 Christian Grothoff Assigned To user457 =>
2009-12-24 22:37 Christian Grothoff Status assigned => confirmed
2010-06-22 00:09 Christian Grothoff Status confirmed => assigned
2010-06-22 00:09 Christian Grothoff Assigned To => Christian Grothoff
2010-06-22 18:31 Christian Grothoff Note Added: 0004043
2010-06-22 18:31 Christian Grothoff Status assigned => resolved
2010-06-22 18:31 Christian Grothoff Resolution open => fixed
2010-07-03 20:55 Christian Grothoff Status resolved => closed