View Issue Details

IDProjectCategoryView StatusLast Update
0010013Talerexchangepublic2025-05-26 14:42
ReporterFlorian Dold Assigned ToFlorian Dold  
PrioritynormalSeverityminorReproducibilityhave not tried
Status resolvedResolutionfixed 
Target Version1.0 stretch goals 
Summary0010013: AML programs do not receive input new_rules.custom_measures despite it being mandatory in the spec
DescriptionThat means that rules don't round-trip nicely, making it more difficult than necessary to keep the current rules.
TagsNo tags attached.

Activities

Christian Grothoff

2025-05-26 00:34

manager   ~0024992

That's strange, we don't really touch the new_rules before passing them through. Do you have a test?

Christian Grothoff

2025-05-26 08:39

manager   ~0024998

It really cannot be: there is no code (!) in the exchange to convert a LegitimizationRuleSet (LRS) to JSON, only to parse the JSON and then to (re)build sub-parts (for wallets/clients) of that JSON. Which means we receive the JSON LRS, store it in JSON in the DB, and always -- if we return any LRS -- return exactly what we received previously. So I suspect you have some helper that threw away the custom_measures (happened to me before...), but it won't be the exchange!

Florian Dold

2025-05-26 09:58

manager   ~0024999

The following test triggers a 500 response on form upload from the exchange, using *only* the helper taler-exchange-helper-measure-inform-investigate shipped with the exchange.

$ taler-harness run-integrationtests kyc-merchant-deposit-form

So either this helper is broken or the exchange isn't passing the LRS correctly. Or maybe not constructing the initial LRS correctly from default rules.

Florian Dold

2025-05-26 14:42

manager   ~0025009

commit f6026688d2c2d42f0c32ba59582213f70a276e2e (HEAD -> master, origin/master, origin/HEAD)
Author: Florian Dold <florian@dold.me>
Date: Mon May 26 14:36:14 2025 +0200

    ensure that default LRS specifies custom_measures
    
    It is a mandatory field.
    
    Issue: https://bugs.taler.net/n/10013

Issue History

Date Modified Username Field Change
2025-05-25 22:26 Florian Dold New Issue
2025-05-25 22:26 Florian Dold Status new => assigned
2025-05-25 22:26 Florian Dold Assigned To => Christian Grothoff
2025-05-26 00:34 Christian Grothoff Note Added: 0024992
2025-05-26 08:39 Christian Grothoff Note Added: 0024998
2025-05-26 08:39 Christian Grothoff Assigned To Christian Grothoff => Florian Dold
2025-05-26 08:39 Christian Grothoff Status assigned => feedback
2025-05-26 09:58 Florian Dold Note Added: 0024999
2025-05-26 09:58 Florian Dold Assigned To Florian Dold => Christian Grothoff
2025-05-26 09:58 Florian Dold Status feedback => assigned
2025-05-26 13:03 Florian Dold Assigned To Christian Grothoff => Florian Dold
2025-05-26 14:42 Florian Dold Status assigned => resolved
2025-05-26 14:42 Florian Dold Resolution open => fixed
2025-05-26 14:42 Florian Dold Note Added: 0025009