View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0007300 | Taler | bank API (C) | public | 2022-08-16 08:03 | 2023-11-29 00:30 |
| Reporter | Christian Grothoff | Assigned To | Florian Dold | Resolution deadline | |
| Implementer | Reviewer | ||||
| Release signed by | Deployed by | ||||
| Verifier | Communicator | ||||
| Data protection authority notification required | No | ||||
| CSIRT notification required | No | ||||
| Estimated effort (hours) | Actual effort (hours) | 0 | |||
| Fast-track | No | ||||
| Work package | none | ||||
| Priority | immediate | Severity | tweak | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Platform | i7 | OS | Debian GNU/Linux | OS Version | squeeze |
| Product Version | git (master) | ||||
| Target Version | 0.9.3 | Fixed in Version | 0.9.3 | ||
| Summary | 0007300: Taler bank access API does not follow conventions | ||||
| Description | https://docs.taler.net/core/api-bank-access.html has camelCase in field names while we use only snail_style in the rest of our APIs. Furthermore, a date is listed as a string using "// YYYY-MM-DD ending with 'Z'" for the format, which is NOT the date format we use in Taler. And the /config endpoint for API versioning is absent :-(. Changing this will require coordinated changes to fakebank, libeufin, and cashier. | ||||
| Tags | No tags attached. | ||||
| related to | 0007275 | closed | Christian Grothoff | debit_account / credit_account are highly redundant in bank-api transaction histories |
| As privately discussed, /config now responds at: /demobanks/default/integration-api/config | |
| Latest cashier is using this strange URL now. Not sure what else is left here to do. | |
| Is there anything left to do for this ticket? | |
| I still see camel-case: "accountLabel" and "publicAccounts" and "paytoUri" in the API specs (and more further down). So clearly the camelCase has not been addressed yet. And there is also still "date: string; // milliseconds since the Unix epoch", which isn't _exactly_ how we usually do dates in our API. | |
| docs.git:: 898e0199..8df41796 fixes the *specification* to address this issue, but NOT libeufin. Marcello: please fix libeufin ASAP. | |
| Outdated issue, does not apply anymore to the current code. | |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2022-08-16 08:03 | Christian Grothoff | New Issue | |
| 2022-08-16 08:03 | Christian Grothoff | Status | new => assigned |
| 2022-08-16 08:03 | Christian Grothoff | Assigned To | => Christian Grothoff |
| 2022-08-16 08:04 | Christian Grothoff | Assigned To | Christian Grothoff => grote |
| 2022-09-15 07:27 | MS | Note Added: 0019134 | |
| 2022-10-20 09:19 | Christian Grothoff | Target Version | 0.9 => 0.9.1 |
| 2022-12-20 17:26 | Christian Grothoff | Target Version | 0.9.1 => 0.9.2 |
| 2023-01-03 14:31 | grote | Note Added: 0019557 | |
| 2023-01-31 17:59 | grote | Assigned To | grote => Christian Grothoff |
| 2023-01-31 17:59 | grote | Status | assigned => feedback |
| 2023-01-31 17:59 | grote | Note Added: 0019723 | |
| 2023-02-01 23:23 | Christian Grothoff | Note Added: 0019734 | |
| 2023-02-01 23:24 | Christian Grothoff | Assigned To | Christian Grothoff => MS |
| 2023-02-01 23:24 | Christian Grothoff | Status | feedback => assigned |
| 2023-02-17 16:52 | Florian Dold | Target Version | 0.9.2 => 0.9.3 |
| 2023-09-03 13:38 | Christian Grothoff | Note Added: 0020484 | |
| 2023-09-03 15:36 | Christian Grothoff | Relationship added | related to 0007275 |
| 2023-09-03 16:01 | Christian Grothoff | Priority | normal => immediate |
| 2023-09-23 13:02 | Christian Grothoff | Assigned To | MS => Florian Dold |
| 2023-11-09 11:20 | MS | Status | assigned => informing |
| 2023-11-09 11:20 | MS | Resolution | open => fixed |
| 2023-11-09 11:20 | MS | Note Added: 0020631 | |
| 2023-11-29 00:29 | Christian Grothoff | Fixed in Version | => 0.9.3 |
| 2023-11-29 00:30 | Christian Grothoff | Status | informing => closed |