View Issue Details

IDProjectCategoryView StatusLast Update
0007275Talerspecificationpublic2024-01-12 13:03
ReporterChristian Grothoff Assigned ToChristian Grothoff Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PriorityimmediateSeveritytweakReproducibilityN/A
Status closedResolutionfixed 
Platformi7OSDebian GNU/LinuxOS Versionsqueeze
Target Version0.9.3Fixed in Version0.9.3 
Summary0007275: debit_account / credit_account are highly redundant in bank-api transaction histories
DescriptionWhen requesting a credit/debit history, the affected account is repeated in every single entry of the account history.
This wastes bandwidth and computation time (parsing!) and is simply inelegant. We should refactor the API to only return the main account the credit/debit histories are for ONCE (or zero? after all, the client should know what it requested?), and certainly not for every transaction.

Note: this change needs to be coordinated across all bank clients and implementations.
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Relationships

related to 0007300 closedFlorian Dold Taler bank access API does not follow conventions 

Activities

Christian Grothoff

2023-09-03 15:36

manager   ~0020485

Let's fix this together with 0007300.

Christian Grothoff

2023-09-03 15:55

manager   ~0020486

Fixed in docs.git.

Christian Grothoff

2023-09-03 15:59

manager   ~0020487

5adf8fab..d289bb87 changes merchant.git (Anastasis/merchant facade) to use the non-redundant API style.

Christian Grothoff

2023-09-03 16:00

manager   ~0020488

exchange.git::f7de830b..fd6a1d1a modifies the exchange bank and fakebank to use the new non-redundant style.

MS

2023-09-05 07:35

reporter   ~0020494

libeufin.git at 7ccac24e29bd825ac2e0e721226ccabde6d947cc got changed after this bug. Setting as feedback until tests from the exchange code-base confirm the correctness.

Christian Grothoff

2023-09-05 12:58

manager   ~0020502

Can't yet confirm, as all tests were migrated to fakebank and/or are commented out because they were failing for a while. Will investigate.

Christian Grothoff

2023-09-23 12:59

manager   ~0020524

Solved at least in fakebank, libeufin will have it fixed once 0.9.3 is out.

Issue History

Date ModifiedUsernameFieldChange
2022-07-05 11:12Christian GrothoffNew Issue
2022-07-05 11:12Christian GrothoffStatusnew => assigned
2022-07-05 11:12Christian GrothoffAssigned To => Christian Grothoff
2022-07-05 12:55Christian GrothoffAssigned ToChristian Grothoff => MS
2022-11-02 14:32Christian GrothoffPriorityurgent => normal
2022-12-20 18:38Christian GrothoffTarget Version => 0.11
2023-09-03 15:35Christian GrothoffTarget Version0.11 => 0.9.3
2023-09-03 15:36Christian GrothoffNote Added: 0020485
2023-09-03 15:36Christian GrothoffRelationship addedrelated to 0007300
2023-09-03 15:55Christian GrothoffNote Added: 0020486
2023-09-03 15:59Christian GrothoffNote Added: 0020487
2023-09-03 16:00Christian GrothoffNote Added: 0020488
2023-09-03 16:00Christian GrothoffPrioritynormal => immediate
2023-09-05 07:35MSNote Added: 0020494
2023-09-05 07:35MSStatusassigned => feedback
2023-09-05 12:58Christian GrothoffAssigned ToMS => Christian Grothoff
2023-09-05 12:58Christian GrothoffNote Added: 0020502
2023-09-23 12:59Christian GrothoffStatusfeedback => informing
2023-09-23 12:59Christian GrothoffResolutionopen => fixed
2023-09-23 12:59Christian GrothoffFixed in Version => 0.9.3
2023-09-23 12:59Christian GrothoffNote Added: 0020524
2023-09-23 13:09Christian GrothoffStatusinforming => closed
2024-01-12 13:03Christian GrothoffCategoryexchange API (HTTP specification) => specification