View Issue Details

IDProjectCategoryView StatusLast Update
0005041Talerwallet (WebExtension)public2017-06-06 12:18
ReporterFlorian Dold Assigned ToFlorian Dold Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Product Versiongit (master) 
Target Version0.3Fixed in Version0.3 
Summary0005041: do not allow the merchant to directly send proposal to wallet, which could circumvent nonce check
DescriptionThe API offered by the content script of the wallet should only accept URLs and not proposal objects.

This also simplifies the code.
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Relationships

related to 0005040 closedFlorian Dold use wallet api lib instead of duplicated helpers in content script, since dead code elimination is available now 

Activities

Florian Dold

2017-05-31 15:11

manager   ~0012199

Fixed around 613a14c14.

The wallet API offered to normal pages can't directly give a contract to the wallet anymore. The wallet will always do the fetching and nonce checking.

Issue History

Date ModifiedUsernameFieldChange
2017-05-29 11:34Florian DoldNew Issue
2017-05-29 11:34Florian DoldStatusnew => assigned
2017-05-29 11:34Florian DoldAssigned To => Florian Dold
2017-05-29 11:34Florian DoldRelationship addedrelated to 0005040
2017-05-31 15:11Florian DoldStatusassigned => informing
2017-05-31 15:11Florian DoldResolutionopen => fixed
2017-05-31 15:11Florian DoldNote Added: 0012199
2017-06-02 07:35Christian GrothoffProduct Version => git (master)
2017-06-02 07:35Christian GrothoffFixed in Version => 0.3
2017-06-02 07:35Christian GrothoffTarget Version => 0.3
2017-06-06 12:18Christian GrothoffStatusinforming => closed
2023-04-13 18:37Florian DoldCategorywallet (WebExtensions) => wallet (WebExtension)