View Issue Details

IDProjectCategoryView StatusLast Update
0005040Talerwallet (WebExtension)public2017-06-06 12:18
ReporterFlorian Dold Assigned ToFlorian Dold Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Product Versiongit (master) 
Target Version0.3Fixed in Version0.3 
Summary0005040: use wallet api lib instead of duplicated helpers in content script, since dead code elimination is available now
DescriptionWe still have custom, duplicate helper functions in the content script, from the time where we weren't using a module bundler (but SystemJS).

Since dead code elimination now should work, we can just use the libraries we have, removing duplication and making the code more readable.
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Relationships

related to 0005041 closedFlorian Dold do not allow the merchant to directly send proposal to wallet, which could circumvent nonce check 

Activities

Florian Dold

2017-05-31 15:11

manager   ~0012200

Fixed around 613a14c14.

Issue History

Date ModifiedUsernameFieldChange
2017-05-29 10:58Florian DoldNew Issue
2017-05-29 10:58Florian DoldStatusnew => assigned
2017-05-29 10:58Florian DoldAssigned To => Florian Dold
2017-05-29 11:34Florian DoldRelationship addedrelated to 0005041
2017-05-31 15:11Florian DoldStatusassigned => informing
2017-05-31 15:11Florian DoldResolutionopen => fixed
2017-05-31 15:11Florian DoldNote Added: 0012200
2017-06-02 07:35Christian GrothoffProduct Version => git (master)
2017-06-02 07:35Christian GrothoffFixed in Version => 0.3
2017-06-02 07:35Christian GrothoffTarget Version => 0.3
2017-06-06 12:18Christian GrothoffStatusinforming => closed
2023-04-13 18:37Florian DoldCategorywallet (WebExtensions) => wallet (WebExtension)