View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0005020 | Taler | obsolete component | public | 2017-05-20 18:36 | 2017-11-20 11:14 |
| Reporter | Christian Grothoff | Assigned To | Marcello Stanisci | Resolution deadline | |
| Implementer | Reviewer | ||||
| Release signed by | Deployed by | ||||
| Verifier | Communicator | ||||
| Data protection authority notification required | No | ||||
| CSIRT notification required | No | ||||
| Estimated effort (hours) | Actual effort (hours) | 0 | |||
| Fast-track | No | ||||
| Work package | none | ||||
| Priority | normal | Severity | tweak | Reproducibility | N/A |
| Status | closed | Resolution | fixed | ||
| Platform | i7 | OS | Debian GNU/Linux | OS Version | squeeze |
| Product Version | git (master) | ||||
| Target Version | 0.5 | ||||
| Summary | 0005020: taler bank should be subjected to static analysis | ||||
| Description | There are a bunch of tools for Python static analysis: https://blog.codacy.com/review-of-python-static-analysis-tools-ff8e7e27f972 We should integrate those into our development process, including running some either as part of normal build targets (i.e. 'make pylint') and/or as part of the buildbot (depending on the tool). | ||||
| Tags | No tags attached. | ||||
| pylint3 seems useful. We should run (as part of buildbot): pylint3 --load-plugins pylint_django talerbank/ and non-empty output should cause failures of the test. Note that this requires: $ pip3 install pylint-django (and that we may need a custom configuration to disable warnings we find acceptable). | |
| 'make pylint' is available (from 54cc782); however, this doesn't mean the code is cleaned! Can we close this, or keep it open as a reminder to clean the code? | |
| There's also mypy (http://mypy-lang.org/), which is to Python kind of like TypeScript is to JavaScript. Python already supports type annotations, this project checks them. | |
| Setting this up should also be beneficial for the Saleor/django-payments logic. | |
| Closing this becasue all the machinery (code checker / BB worker) has been set up, and now it's only a matter of addressing the various code imperfections. However, I'm going to append note 12376 under the 0005021, that addresses doxygen for Python. | |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2017-05-20 18:36 | Christian Grothoff | New Issue | |
| 2017-05-20 18:36 | Christian Grothoff | Status | new => assigned |
| 2017-05-20 18:36 | Christian Grothoff | Assigned To | => Marcello Stanisci |
| 2017-05-22 12:21 | Christian Grothoff | Note Added: 0012143 | |
| 2017-07-30 08:11 | Marcello Stanisci | Note Added: 0012372 | |
| 2017-08-14 09:26 | Florian Dold | Note Added: 0012376 | |
| 2017-10-23 08:39 | Christian Grothoff | Target Version | => 0.5 |
| 2017-10-23 08:39 | Christian Grothoff | Note Added: 0012505 | |
| 2017-11-20 11:14 | Marcello Stanisci | Status | assigned => closed |
| 2017-11-20 11:14 | Marcello Stanisci | Resolution | open => fixed |
| 2017-11-20 11:14 | Marcello Stanisci | Note Added: 0012588 | |
| 2022-08-23 18:26 | Christian Grothoff | Category | bank (demonstrator) => py bank (demonstrator, obsolete) |
| 2023-12-03 00:23 | Christian Grothoff | Category | py bank (demonstrator, obsolete) => obsolete componet |
| 2023-12-11 19:08 | Florian Dold | Category | obsolete componet => obsolete component |