View Issue Details

IDProjectCategoryView StatusLast Update
0005021Talerobsolete componentpublic2019-12-20 18:12
ReporterChristian Grothoff Assigned ToMarcello Stanisci Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PrioritynormalSeveritytextReproducibilityhave not tried
Status closedResolutionfixed 
Platformi7OSDebian GNU/LinuxOS Versionsqueeze
Product Version0.3 
Target Version0.6Fixed in Version0.6 
Summary0005021: python logic should be documented in doxygen-compatible style
DescriptionSee the 2nd style "##" under:

http://www.stack.nl/~dimitri/doxygen/manual/docblocks.html#pythonblocks

Basically, each module, class function, argument and return value should be documented. (Not only for the bank, but -especially- the Python frontends).
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Activities

Marcello Stanisci

2019-03-06 14:28

reporter   ~0014151

The link in the description is not working anymore. Use the following: http://www.doxygen.nl/manual/docblocks.html#pythonblocks

Marcello Stanisci

2019-03-06 17:00

reporter   ~0014154

All the pythons now have a Doxygen file, and the bank has some little amount of doxygen-commented code. However, a quick-and-dirty doxygen run at the bank didn't produce any useful output. Needs investigation.

Marcello Stanisci

2019-03-06 17:06

reporter   ~0014157

Fixed here: b8761e7..eec9e0e

Marcello Stanisci

2019-03-06 17:07

reporter   ~0014158

We keep this open until all the code has been commented.

Marcello Stanisci

2019-03-12 17:06

reporter   ~0014190

All the main *.py from the bank and frontends got commented. I'm leaving this open since also the *.in "manage scripts" should be Doxygen-commented.

Marcello Stanisci

2019-03-13 14:29

reporter   ~0014192

Last edited: 2019-03-13 14:30

All the *.in got now commented in all the codebases. The commenting might not be perfect everywhere, but all the infrastructure is set up, and all the main files got commented, so this issue can be closed in my opinion.

The fix:
After mapping in-files to the Python engine (MAPPING_EXTENSION option),
the real unblocker was to set EXTRACT_ALL = YES, as standalone scripts do not
usually have classes defined (therefore Doxygen ignores such files, by default).

Issue History

Date ModifiedUsernameFieldChange
2017-05-22 12:32Christian GrothoffNew Issue
2017-05-22 12:32Christian GrothoffStatusnew => assigned
2017-05-22 12:32Christian GrothoffAssigned To => Marcello Stanisci
2017-12-14 14:53Christian GrothoffTarget Version => 0.7.1
2019-03-06 14:28Marcello StanisciNote Added: 0014151
2019-03-06 17:00Marcello StanisciNote Added: 0014154
2019-03-06 17:06Marcello StanisciNote Added: 0014157
2019-03-06 17:07Marcello StanisciNote Added: 0014158
2019-03-12 17:06Marcello StanisciNote Added: 0014190
2019-03-13 14:29Marcello StanisciNote Added: 0014192
2019-03-13 14:30Marcello StanisciStatusassigned => informing
2019-03-13 14:30Marcello StanisciResolutionopen => fixed
2019-03-13 14:30Marcello StanisciNote Edited: 0014192
2019-03-15 04:41Christian GrothoffFixed in Version => 0.6
2019-03-15 04:41Christian GrothoffTarget Version0.7.1 => 0.6
2019-12-20 18:12Christian GrothoffStatusinforming => closed
2022-08-23 18:26Christian GrothoffCategorybank (demonstrator) => py bank (demonstrator, obsolete)
2023-12-03 00:23Christian GrothoffCategorypy bank (demonstrator, obsolete) => obsolete componet
2023-12-11 19:08Florian DoldCategoryobsolete componet => obsolete component