View Issue Details

IDProjectCategoryView StatusLast Update
0009797Talertaler-harnesspublic2025-04-29 14:28
ReporterFlorian Dold Assigned ToFlorian Dold  
PrioritynormalSeverityminorReproducibilityhave not tried
Status resolvedResolutionfixed 
Target Version1.0 
Summary0009797: harness test kyc-merchant-deposit-rewrite unclear
DescriptionIt's unclear to me whether the test (originally written by Sebastian) is expected to even work like it is currently written or not.

The test starts with a deposit limit for merchants of zero. The AML officer then lifts the limit for a particular account.
Then the test expects the merchant backend to update the KYC status ("GET .../private/kyc") by running kyccheck and depositcheck in test mode (-t).

Is this even expected to work?

The other (passing!) integration test triggers the KYC status update by POSTing an order.
TagsNo tags attached.

Activities

Christian Grothoff

2025-04-26 10:38

manager   ~0024683

Yes, it should work, but again possibly with timetravel. taler-merchant-kyccheck is supposed to check about our exchange KYC status independent of "incidents". However, the frequency is capped at once per 6h, so you'll need to timetravel taler-merchant-kyccheck at least 6h into the future.

Florian Dold

2025-04-28 23:54

manager   ~0024700

I have *not* added the time travel yet.

However, the test currently times out for me directly in the first step after setup, since taler-merchant-kyccheck *hangs* despite passing "-t". Note that there is another taler-merchant-kyccheck running in the background already.

You can either see from the logs that kyccheck hangs, or I can write another harness test to reproduce just the hanging.

WDYT?

Christian Grothoff

2025-04-29 01:09

manager   ~0024703

Let me look into it.

Christian Grothoff

2025-04-29 01:30

manager   ~0024704

c592a1c6..924fa10a fixes the hang: we were long-polling at the exchange. With the patch, we are no longer long-polling in test mode and the process exits virtually immediately. Test still fails...

Florian Dold

2025-04-29 14:28

manager   ~0024707

Test passes now after having fixed a bad assertion in the harness.

Curiously, it passes without requiring time travel.

Issue History

Date Modified Username Field Change
2025-04-26 01:14 Florian Dold New Issue
2025-04-26 01:14 Florian Dold Status new => assigned
2025-04-26 01:14 Florian Dold Assigned To => Christian Grothoff
2025-04-26 10:38 Christian Grothoff Note Added: 0024683
2025-04-26 10:38 Christian Grothoff Assigned To Christian Grothoff => Florian Dold
2025-04-28 23:54 Florian Dold Note Added: 0024700
2025-04-28 23:54 Florian Dold Assigned To Florian Dold => Christian Grothoff
2025-04-29 01:09 Christian Grothoff Note Added: 0024703
2025-04-29 01:30 Christian Grothoff Note Added: 0024704
2025-04-29 01:31 Christian Grothoff Assigned To Christian Grothoff => Florian Dold
2025-04-29 14:28 Florian Dold Status assigned => resolved
2025-04-29 14:28 Florian Dold Resolution open => fixed
2025-04-29 14:28 Florian Dold Note Added: 0024707