|
|
"Balances" is not a button, it was never meant to, it is not an Android thing. Whenever you click a balance item, the title should change to "Transactions." However, I just noticed that the German translation is wrong, and says "Salden" in both views. image.png (91,002 bytes) image-2.png (74,469 bytes) image-3.png (59,268 bytes) image-4.png (90,733 bytes) |
|
|
I just fixed this in Weblate, it should now say "Transaktionen." |
|
|
Eh, wait, that seems worse. What does the button say on iOS? And it is a button on iOS. As I said: please let's converge, not diverge! |
|
|
(1) Both buttons in the iOS and the Android apps are labelled "Balances" respectively "Salden" - which is right (iOS: TalerWallet1/Localizable.xcstrings///TitleBalances, Android: balances_title). (2) Both apps have a clickable button in the main menu which makes sense as users want to get to the balances overview page by the tip of a finger, especially when their wallets bear multiple currencies. (3) I think Iván made the right change in Weblate (from "Salden" to "Transaktionen" for the German translation of the key transactions_title) (4) The key transactions_title is only deployed on Android while completely missing in iOS - which is OK for the user experience (5) IMHO we better agree with the state as it is now. I will push Iváns change from Weblate to the git repo this afternoon if nobody objects. |
|
|
> Eh, wait, that seems worse. What does the button say on iOS? And it is a button on iOS. As I said: please let's converge, not diverge! 1) It is not worse, "Transactions" describes what's currently on-screen, not "Balances." 1) No, let's not converge at the expense of platform conventions, toolbar titles are NEVER buttons on Android. 2) There must be only ONE way to do something, you said that to me once also regarding a button to go back. |
|
|
@Stefan I agree, regardless of the UI state itself, I believe the string `transactions_title` should say "Transactions" in all languages. Sorry for not discussing it with you first, it was too small of a change and too obvious for me that it didn't cross my head. |
|
|
Eh, I'm sorry, but I'm not talking about the *title* of anything here. I'm talking about the button left of the action button with the Taler-logo. In your screenshots, that's labeled "Salden" and that button is not working. |
|
|
Ah okay! You're right, that button should indeed take back to the balances list, I'll fix it! |
|
|
commit 34a6ecc6d2d428e8f52d1fe99960fc7acecc09f1 Author: Iván Ávalos <avalos@disroot.org> Date: Wed Apr 9 11:20:04 2025 +0200 [wallet] "Balances" tab now cleans selected scope bug 0009701 |
- Anonymous
