View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0009675 | Taler | wallet (Android App) | public | 2025-03-29 20:26 | 2025-04-30 22:14 |
| Reporter | Christian Grothoff | Assigned To | avalos | ||
| Priority | urgent | Severity | block | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Platform | i7 | OS | Debian GNU/Linux | OS Version | squeeze |
| Product Version | git (master) | ||||
| Target Version | 1.0 | Fixed in Version | 1.0 | ||
| Summary | 0009675: repurchase fails with "This transaction has failed or been abandoned" (when it wasn't). | ||||
| Description | I tried to test repurchase. It fails -- like on iOS -- just differently. Using nightly from ~2 days ago. | ||||
| Steps To Reproduce | - Install Firefox+Webextension - Withdraw KUDOS to Android wallet - Select article from shop - in WebEx wallet, do NOT pay but show QR code - scan QR code, pay with Android wallet (works!) - open article *again* in a new private window - in WebEx wallet, show again QR code to Android - scan QR code, caboom. - expected behavior: this article was bought previously, auto-pay, WebExtension wallet redirects to article + offer to open on local device (see also what iOS wallet does -- note it also has failure modes, just different ones ;-)). Note: if you pay with the WebExtension and then open in a private window, repurchase detection works nicely. | ||||
| Tags | No tags attached. | ||||
|
|
This is because I'm getting the transaction state failed(paid-by-other) from wallet-core, should I render this minor state as “Order was already paid”? Other than that, I don't think I can do anything UI side, this could be a wallet-core issue. |
|
|
commit 2aaa990e7e22eec09eab370f4aeb6e1e1c45903f (HEAD -> master, origin/master, origin/HEAD) Author: Florian Dold <florian@dold.me> Date: Tue Apr 1 23:00:52 2025 +0200 wallet-core: fix bad feature interaction in merchant payments Due to overloading of the "shared" flag, repurchase detection would go wrong for shared orders. |
|
|
@avalos please test if this is still reproducible with the current wallet-core. |
|
|
I just posted a screen recording to wallet UI in Mattermost showing the current behavior. Oddly enough, a new transaction with state failed(repurchase) is created, is this the intended behavior? |
|
|
No, it should never 'fail' in the scenario I described, just go for 'already paid' or 'paid' and offer to show the article. |
|
|
fdold-work@sapota ~/r/t/taler-typescript-core (master)> git log commit 51d2d831b0a6831cc7f722b0f0358ee073e52635 (HEAD -> master, origin/master, origin/HEAD) Author: Florian Dold <florian@dold.me> Date: Wed Apr 16 15:27:55 2025 +0200 wallet-core: hide repurchase transactions by default, delete them when parent tx gets deleted |
|
|
Fixed as per the above commit message in 0.14.15. @avalos: Please deploy and test. |
|
|
Could no longer reproduce in latest Android wallet, feel free to reopen if this still persists. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2025-03-29 20:26 | Christian Grothoff | New Issue | |
| 2025-03-29 20:26 | Christian Grothoff | Status | new => assigned |
| 2025-03-29 20:26 | Christian Grothoff | Assigned To | => avalos |
| 2025-04-01 17:36 | avalos | Note Added: 0024361 | |
| 2025-04-01 18:04 | avalos | Assigned To | avalos => Florian Dold |
| 2025-04-01 18:04 | avalos | Status | assigned => feedback |
| 2025-04-01 23:12 | Florian Dold | Note Added: 0024369 | |
| 2025-04-01 23:13 | Florian Dold | Note Added: 0024370 | |
| 2025-04-01 23:13 | Florian Dold | Assigned To | Florian Dold => avalos |
| 2025-04-03 13:36 | avalos | Note Added: 0024385 | |
| 2025-04-03 15:05 | avalos | Note Edited: 0024385 | |
| 2025-04-03 16:04 | avalos | Assigned To | avalos => Christian Grothoff |
| 2025-04-04 14:19 | Christian Grothoff | Note Added: 0024400 | |
| 2025-04-04 14:19 | Christian Grothoff | Assigned To | Christian Grothoff => Florian Dold |
| 2025-04-04 14:19 | Christian Grothoff | Status | feedback => assigned |
| 2025-04-16 15:28 | Florian Dold | Note Added: 0024577 | |
| 2025-04-16 15:29 | Florian Dold | Note Added: 0024578 | |
| 2025-04-16 15:29 | Florian Dold | Assigned To | Florian Dold => avalos |
| 2025-04-18 15:26 | Christian Grothoff | Target Version | 1.0 => 1.0 stretch goals |
| 2025-04-22 11:02 | avalos | Status | assigned => acknowledged |
| 2025-04-22 13:02 | Christian Grothoff | Status | acknowledged => assigned |
| 2025-04-23 19:17 | avalos | Relationship added | has duplicate 0009750 |
| 2025-04-23 20:06 | avalos | Relationship deleted | has duplicate 0009750 |
| 2025-04-30 22:11 | avalos | Status | assigned => resolved |
| 2025-04-30 22:11 | avalos | Resolution | open => fixed |
| 2025-04-30 22:11 | avalos | Note Added: 0024736 | |
| 2025-04-30 22:14 | Christian Grothoff | Fixed in Version | => 1.0 |
| 2025-04-30 22:14 | Christian Grothoff | Target Version | 1.0 stretch goals => 1.0 |
