View Issue Details

IDProjectCategoryView StatusLast Update
0009675Talerwallet (Android App)public2025-04-01 23:13
ReporterChristian Grothoff Assigned Toavalos  
PriorityurgentSeverityblockReproducibilityalways
Status feedbackResolutionopen 
Platformi7OSDebian GNU/LinuxOS Versionsqueeze
Product Versiongit (master) 
Target Version1.0 
Summary0009675: repurchase fails with "This transaction has failed or been abandoned" (when it wasn't).
DescriptionI tried to test repurchase. It fails -- like on iOS -- just differently. Using nightly from ~2 days ago.
Steps To Reproduce- Install Firefox+Webextension
- Withdraw KUDOS to Android wallet
- Select article from shop
- in WebEx wallet, do NOT pay but show QR code
- scan QR code, pay with Android wallet (works!)
- open article *again* in a new private window
- in WebEx wallet, show again QR code to Android
- scan QR code, caboom.
- expected behavior: this article was bought previously, auto-pay, WebExtension wallet redirects to article + offer to open on local device (see also what iOS wallet does -- note it also has failure modes, just different ones ;-)).

Note: if you pay with the WebExtension and then open in a private window, repurchase detection works nicely.
TagsNo tags attached.

Activities

avalos

2025-04-01 17:36

reporter   ~0024361

This is because I'm getting the transaction state failed(paid-by-other) from wallet-core, should I render this minor state as “Order was already paid”? Other than that, I don't think I can do anything UI side, this could be a wallet-core issue.

Florian Dold

2025-04-01 23:12

reporter   ~0024369

commit 2aaa990e7e22eec09eab370f4aeb6e1e1c45903f (HEAD -> master, origin/master, origin/HEAD)
Author: Florian Dold <florian@dold.me>
Date: Tue Apr 1 23:00:52 2025 +0200

    wallet-core: fix bad feature interaction in merchant payments
    
    Due to overloading of the "shared" flag, repurchase detection would go
    wrong for shared orders.

Florian Dold

2025-04-01 23:13

reporter   ~0024370

@avalos please test if this is still reproducible with the current wallet-core.

Issue History

Date Modified Username Field Change
2025-03-29 20:26 Christian Grothoff New Issue
2025-03-29 20:26 Christian Grothoff Status new => assigned
2025-03-29 20:26 Christian Grothoff Assigned To => avalos
2025-04-01 17:36 avalos Note Added: 0024361
2025-04-01 18:04 avalos Assigned To avalos => Florian Dold
2025-04-01 18:04 avalos Status assigned => feedback
2025-04-01 23:12 Florian Dold Note Added: 0024369
2025-04-01 23:13 Florian Dold Note Added: 0024370
2025-04-01 23:13 Florian Dold Assigned To Florian Dold => avalos