View Issue Details

IDProjectCategoryView StatusLast Update
0009536Talerwallet (WebExtension)public2025-05-30 14:53
ReporterChristian Grothoff Assigned Tovlada.svirsh  
PriorityhighSeverityminorReproducibilityalways
Status feedbackResolutionopen 
Platformi7OSDebian GNU/LinuxOS Versionsqueeze
Product Versiongit (master) 
Target Version1.0 stretch goals 
Summary0009536: two CHF exchanges and weirdness everywhere (also: global vs. regional exchange settings borked)
DescriptionThe "make global" button in the dev settings remains after I click it. It at first doens't seem to do anything. Only when I go back to the page later, I see that the currency was marked regional and there is a new "Make regional" button. So the UI is stale, should instead actually update immediately after pressing the button!

When alternating between my two CHF exchanges via the "Balance"-currency selector, I just see "CHF" in both cases, so I cannot tell BFH-CHF from NETZBON-CHF. For non-global currencies, *especially* if there are multiple, we should include the domain name!

After manually adding the taler-ops.ch exchange via dev settings, I now have two exchanges with CHF in my browser. I then set the TOPS-BFH to be "global". However, afterwards, even though taler-ops.ch is a very virgin exchange and new to the wallet, *some* (not all!) of the CHF transactions of the BFH-CHF deployment show up in my transaction history when I select the TOPS-CHF exchange! Setting TOPS-CHF back to 'regional' makes the transaction history empty again (as it should be).



TagsNo tags attached.

Relationships

parent of 0009998 feedback CHF exchange confusion 
Not all the children of this issue are yet resolved or closed.

Activities

Christian Grothoff

2025-02-14 12:46

manager   ~0024083

non-empty.png (75,086 bytes)   
non-empty.png (75,086 bytes)   

Christian Grothoff

2025-02-14 13:57

manager   ~0024086

The same staleness problem on the dev tools page also applies to other buttons, like I clicked on "delete" and the exchange I deleted didn't go away -- until I reloaded the page.

sebasjm

2025-02-14 22:06

developer   ~0024093

first part, about the button not updating the UI screen, is fixed

Christian Grothoff

2025-05-17 09:41

manager   ~0024923

I now have CHF from both the BFH exchange and the TOPS exchange in my wallet. However, even after I selected the TOPS exchange explicitly, I cannot 'send' CHF from the TOPS exchange as it ALWAYS then picks the BFH exchange. So it only matches by currency, and not by the *selected* exchange! Very bad blocker for my demo today :-(

sebasjm

2025-05-27 22:11

developer   ~0025030

added a new balance UI selector

6006fc80d..5d804540d

sebasjm

2025-05-27 22:14

developer   ~0025031

in this setup i have 2 exchanges with currency LAIA (one is global and the other is regional)

the regional currencies are under the domain name of the exchange

sebasjm

2025-05-27 23:16

developer   ~0025033

FTR only the currency is clickable, but exchanage scope is under a grouped using the exchange URL.

I'm limited to use optgroup here [1] otherwise i will need to rewrite the full select box.

[1] https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/optgroup

Christian Grothoff

2025-05-29 09:26

manager   ~0025046

I'm not sure this makes sense. You're now obscuring the exchange URL for the global currency. Sure, it's less relevant in that case, but it might confuse the user to NOT see it in that case. I'm also not sure the grouped using exchange URL is ideal. My suggestion: put everythign in one line ("CHF via exchange.taler-ops.ch") and maybe use bold-face for global currencies (just on the "CHF", so "CHF/b> via exchange.taler-ops.ch") to visually distinguish them.

Christian Grothoff

2025-05-29 11:25

manager   ~0025048

Wallet 1.0.12 still fails to honor the exchange selection when trying to initiate a P2P transfer if there are multiple exchanges for the same currency.

sebasjm

2025-05-29 16:56

developer   ~0025055

I found the problem why is not using the correct scope

sebasjm

2025-05-29 17:00

developer   ~0025056

d3948b0d8..21a196769

sebasjm

2025-05-29 17:08

developer   ~0025057

I changed the way you suggedted, what I don't like is the fact that <option> doesn't allow css customization (and I want to avoid refactoring the <select /> component) and doesn't work.

Using <optgroup /> looks nicer. Grouping by currency is reasonable but when the value is selected you see the URL instead of the currency which is not want I want. I want to see the currency in this selector. For clarification, when the scope is not global a small text below the currency is show up to indicate that this is regional currency, global scoped currencies doesn't show the exchange base_url.
image.png (30,069 bytes)   
image.png (30,069 bytes)   
image-2.png (29,197 bytes)   
image-2.png (29,197 bytes)   

Christian Grothoff

2025-05-29 19:01

manager   ~0025058

Ah, didn't realize formatting inside was not supported. I guess grouping by currency and then selecting the exchange does actually make sense --- after all, that gives you first the main choice (which currency) and then nicely (and without redundancy) gives you what you are actually selecting: the exchanges for that currency. So I could live with a list of exchanges grouped by currency where one always has to select a currency. The question is then how to indicate nicely (for 3-letter currencies) that an exchange is not in the "approved" set. Maybe: "unknown provider, risky" might work?

sebasjm

2025-05-29 21:20

developer   ~0025059

What you are seeing is the list of scope, so
 - global scopes will be shown without url (you will see the history of all transactions related to all approved exchanges for this currency)
 - exchange scoped will be shown with the exchange url (this are non-approved exchanges)

I'm adding 4 screens how it looks for your suggestion. There are two exchanges that share the same currency name.
1) when non of the exchange are approved
2) when only one LAIA exchange is approved
3) when both LAIA exchanges are approved
4) when all exchanges are approved

the last screenshot you can see how it looks when the Exchange scope is selected. I can't change this, is the limitation of the <select />.

Grouping by exchange URL (as my first example) look better when the option is selected because it will render the currency name and the url will be below.
image-3.png (62,327 bytes)   
image-3.png (62,327 bytes)   
image-4.png (59,169 bytes)   
image-4.png (59,169 bytes)   
image-5.png (56,020 bytes)   
image-5.png (56,020 bytes)   
image-6.png (56,070 bytes)   
image-6.png (56,070 bytes)   
image-7.png (55,308 bytes)   
image-7.png (55,308 bytes)   

sebasjm

2025-05-29 21:24

developer   ~0025060

I'm pushing the last example, unless other indication. And this issue can't be resolved until the child is resolved first.

Christian Grothoff

2025-05-29 21:36

manager   ~0025061

No, that last one is still not OK. When the menu is not expanded, it fails to show the currency at all.

Suggestion: why not show the currency in a dynamic (non-editable) text field between the drop-down and the number? So we'd have
[exchange dropdown] $CURRENCY $NUMBER
(or conceivably [exchange dropdown] $NUMBER $CURRENCY depending on locale).

The $CURRENCY would, like $NUMBER not be editable.

Also, I see no point in then still putting the exchange domain name under the drop-down, it's now redundant.

Vlada: opinions welcome!

sebasjm

2025-05-29 21:58

developer   ~0025062

For a good comparison, this is the same screenshot in but using my first suggested implementation.

1) when non of the exchange are approved
2) when only one LAIA exchange is approved
3) when both LAIA exchanges are approved
4) when all exchanges are approved
5) when selected, only the currency is shown.

> Suggestion: why not show the currency in a dynamic (non-editable) text field between the drop-down and the number?

it's not a exchange dropdown, you have also global currencies so we could use mix both but I think that's not nice.
The closer to that is usign the dropdown to show currency AND exchange (design 2) but also not perfect.
image-8.png (59,466 bytes)   
image-8.png (59,466 bytes)   
image-9.png (57,301 bytes)   
image-9.png (57,301 bytes)   
image-10.png (55,778 bytes)   
image-10.png (55,778 bytes)   
image-11.png (52,475 bytes)   
image-11.png (52,475 bytes)   
image-12.png (26,785 bytes)   
image-12.png (26,785 bytes)   

vlada.svirsh

2025-05-30 12:56

developer   ~0025069

1) Only one exchange is available for selected currency
2) Possibility for difference views for user
3) Selected exchange is not trusted by developers. On icon hover, show hint "The developers of this wallet do not trust this service provider."


picture from penpot https://penpot.taler.net/#/workspace?team-id=826af720-982c-8096-8006-0dbdd6a758c1&file-id=29e68e1b-4b36-81a2-8006-436e5512dd51&page-id=29e68e1b-4b36-81a2-8006-436e5512dd52


I think separating currencies and exchanges to different dropdowns might be clearer for users
Board.png (34,463 bytes)   
Board.png (34,463 bytes)   

sebasjm

2025-05-30 14:53

developer   ~0025071

I don't think exposing here a list of exchanges is a good idea. The dropdown is about balance scopes https://docs.taler.net/design-documents/035-regional-currencies.html

The exchange URL is only shown when the transactions and money is not REAL money (an exchange need to be approved by an authority to be able to be listed in the wallet as provider of official currency)

Issue History

Date Modified Username Field Change
2025-02-14 12:44 Christian Grothoff New Issue
2025-02-14 12:44 Christian Grothoff Status new => assigned
2025-02-14 12:44 Christian Grothoff Assigned To => sebasjm
2025-02-14 12:46 Christian Grothoff Note Added: 0024083
2025-02-14 12:46 Christian Grothoff File Added: non-empty.png
2025-02-14 12:49 Christian Grothoff Description Updated
2025-02-14 12:51 Christian Grothoff Description Updated
2025-02-14 12:52 Christian Grothoff Summary two CHF exchanges and weirdness everywhere => two CHF exchanges and weirdness everywhere (also: global vs. regional exchange settings borked)
2025-02-14 12:52 Christian Grothoff Description Updated
2025-02-14 13:57 Christian Grothoff Note Added: 0024086
2025-02-14 22:06 sebasjm Note Added: 0024093
2025-04-18 15:20 Christian Grothoff Target Version 1.0 => 1.0 stretch goals
2025-05-17 09:41 Christian Grothoff Note Added: 0024923
2025-05-21 22:27 Christian Grothoff Relationship added parent of 0009998
2025-05-27 22:11 sebasjm Note Added: 0025030
2025-05-27 22:14 sebasjm Note Added: 0025031
2025-05-27 22:14 sebasjm File Added: Screenshot_2025-05-27_17-03-27-2.png
2025-05-27 23:16 sebasjm Note Added: 0025033
2025-05-27 23:16 sebasjm Assigned To sebasjm => Christian Grothoff
2025-05-27 23:16 sebasjm Status assigned => feedback
2025-05-29 09:26 Christian Grothoff Note Added: 0025046
2025-05-29 09:26 Christian Grothoff Assigned To Christian Grothoff => sebasjm
2025-05-29 09:26 Christian Grothoff Status feedback => assigned
2025-05-29 11:25 Christian Grothoff Note Added: 0025048
2025-05-29 16:56 sebasjm Note Added: 0025055
2025-05-29 17:00 sebasjm Note Added: 0025056
2025-05-29 17:08 sebasjm Note Added: 0025057
2025-05-29 17:08 sebasjm File Added: image.png
2025-05-29 17:08 sebasjm File Added: image-2.png
2025-05-29 17:09 sebasjm Assigned To sebasjm => Christian Grothoff
2025-05-29 17:09 sebasjm Status assigned => feedback
2025-05-29 19:01 Christian Grothoff Note Added: 0025058
2025-05-29 19:17 Christian Grothoff Assigned To Christian Grothoff => sebasjm
2025-05-29 19:17 Christian Grothoff Status feedback => assigned
2025-05-29 21:20 sebasjm Note Added: 0025059
2025-05-29 21:20 sebasjm File Added: image-3.png
2025-05-29 21:20 sebasjm File Added: image-4.png
2025-05-29 21:20 sebasjm File Added: image-5.png
2025-05-29 21:20 sebasjm File Added: image-6.png
2025-05-29 21:20 sebasjm File Added: image-7.png
2025-05-29 21:22 sebasjm Assigned To sebasjm => Christian Grothoff
2025-05-29 21:22 sebasjm Status assigned => feedback
2025-05-29 21:24 sebasjm Note Added: 0025060
2025-05-29 21:36 Christian Grothoff Note Added: 0025061
2025-05-29 21:36 Christian Grothoff Assigned To Christian Grothoff => vlada.svirsh
2025-05-29 21:58 sebasjm Note Added: 0025062
2025-05-29 21:58 sebasjm File Added: image-8.png
2025-05-29 21:58 sebasjm File Added: image-9.png
2025-05-29 21:58 sebasjm File Added: image-10.png
2025-05-29 21:58 sebasjm File Added: image-11.png
2025-05-29 21:58 sebasjm File Added: image-12.png
2025-05-30 12:56 vlada.svirsh Note Added: 0025069
2025-05-30 12:56 vlada.svirsh File Added: Board.png
2025-05-30 14:53 sebasjm Note Added: 0025071