View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0009339 | Taler | exchange | public | 2024-11-14 22:17 | 2024-12-13 19:15 |
| Reporter | Florian Dold | Assigned To | Florian Dold | ||
| Priority | normal | Severity | minor | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | ||
| Target Version | 0.14 | Fixed in Version | 0.14 | ||
| Summary | 0009339: some exchange endpoints to not handle NULL jnew_rules | ||||
| Description | The /kyc-info endpoint crashes the when jnew_rules is NULL. Other places in the code might also not handle it well. | ||||
| Tags | No tags attached. | ||||
|
|
I've double-checked taler-exchange-httpd_kyc-info.c, and sebastian fixed a segv just hours *before* this bug was submitted. I fixed a wrong hard error log (GNUNET_break_op()) on this path in 4dedd235d..b18069097, but I really cannot see a segv path from new_rules (or lrs) being NULL. |
|
|
It does crash: commit 3090d60068a6a4a3441fd0e6481190a03c407847 (HEAD -> master, origin/master, origin/HEAD) Author: Florian Dold <florian@dold.me> Date: Thu Nov 21 19:35:26 2024 +0100 harness: extend test-kyc-decision to provoke exchange crash |
|
|
Actually ... it crashes in batch-deposit, so some other bug. |
|
|
Reproducer: $ taler-harness run-integrationtests kyc-decision (Test is *incomplete*, but crashes the exchange.) |
|
|
$ taler-harness run-integrationtests kyc-decision 2024-11-21T22:48:58.765Z testrunner.ts INFO purging shared test environment testsuite root directory: /tmp/taler-integrationtests-HjubIp See /tmp/taler-integrationtests-HjubIp/results.json for details Skipped: 0/0 Failed: 0/0 Passed: 0/0 I get that, instantly. Nothing is run, no exchange is even started... |
|
|
I forgot the "s", it's $ taler-harness run-integrationtests kyc-decisions |
|
|
Crash fixed. Bug fixed? |
|
|
I can still reproduce this, via an integration test that Sebastian contributed. The test is meant to test something else, but: $ taler-harness run-integrationtests kyc-two-forms [ test fails ] In the exchange logs: 2024-12-04T16:41:28.692004+0100 taler-exchange-httpd-1480242(58HP97JXRV6A2ZN76A0HT7R1G8) ERROR NULL field encountered for `jnew_rules' where non-NULL was required 2024-12-04T16:41:28.692050+0100 taler-exchange-httpd-1480242(58HP97JXRV6A2ZN76A0HT7R1G8) ERROR Assertion failed at taler-exchange-httpd_kyc-info.c:613. |
|
|
With the latest exchange, not reproducible anymore. |
|
|
Actually, it's still in the logs, just alongside other errors :-( |
|
|
*Now* it should be fixed. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2024-11-14 22:17 | Florian Dold | New Issue | |
| 2024-11-14 22:17 | Florian Dold | Status | new => assigned |
| 2024-11-14 22:17 | Florian Dold | Assigned To | => Florian Dold |
| 2024-11-20 23:59 | Christian Grothoff | Note Added: 0023739 | |
| 2024-11-20 23:59 | Christian Grothoff | Status | assigned => feedback |
| 2024-11-21 19:37 | Florian Dold | Note Added: 0023743 | |
| 2024-11-21 19:38 | Florian Dold | Note Added: 0023744 | |
| 2024-11-21 19:50 | Florian Dold | Note Added: 0023745 | |
| 2024-11-21 19:50 | Florian Dold | Assigned To | Florian Dold => Christian Grothoff |
| 2024-11-21 23:49 | Christian Grothoff | Note Added: 0023746 | |
| 2024-11-21 23:49 | Christian Grothoff | Assigned To | Christian Grothoff => Florian Dold |
| 2024-11-22 16:58 | Florian Dold | Note Added: 0023747 | |
| 2024-11-22 16:58 | Florian Dold | Assigned To | Florian Dold => Christian Grothoff |
| 2024-11-22 17:03 | Christian Grothoff | Note Added: 0023748 | |
| 2024-11-22 17:03 | Christian Grothoff | Assigned To | Christian Grothoff => Florian Dold |
| 2024-12-04 18:42 | Florian Dold | Note Added: 0023786 | |
| 2024-12-06 11:22 | Florian Dold | Assigned To | Florian Dold => Christian Grothoff |
| 2024-12-06 11:22 | Florian Dold | Status | feedback => resolved |
| 2024-12-06 11:22 | Florian Dold | Resolution | open => fixed |
| 2024-12-06 11:22 | Florian Dold | Note Added: 0023804 | |
| 2024-12-06 11:26 | Florian Dold | Assigned To | Christian Grothoff => Florian Dold |
| 2024-12-06 11:26 | Florian Dold | Status | resolved => assigned |
| 2024-12-06 11:26 | Florian Dold | Note Added: 0023805 | |
| 2024-12-06 11:50 | Florian Dold | Status | assigned => resolved |
| 2024-12-06 11:50 | Florian Dold | Note Added: 0023806 | |
| 2024-12-13 01:59 | Christian Grothoff | Fixed in Version | => 0.14 |
| 2024-12-13 19:15 | Christian Grothoff | Status | resolved => closed |
