View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0009334 | Taler | wallet-core | public | 2024-11-12 13:27 | 2026-03-20 00:01 |
| Reporter | Florian Dold | Assigned To | Florian Dold | ||
| Priority | normal | Severity | minor | Reproducibility | have not tried |
| Status | resolved | Resolution | fixed | ||
| Target Version | 1.5 | ||||
| Summary | 0009334: wallet does not automatically handle expired pay-merchant transactions, payment-expired test also only handles manual case [6h] | ||||
| Description | Test needs to be fixed to cover both cases, wallet-core needs to handle expiration automatically. | ||||
| Tags | No tags attached. | ||||
| parent of | 0010066 | resolved | Florian Dold | expired peer-pull-credit transaction not transitioning to final state [2h] |
|
|
The wallet needs to handle both cases: * it sees from the timestamp that the order is expired (=> does not even attempt to pay) * the merchant claims that the order is expired (=> refresh) Both cases need to be handled in case the payment request takes long (causing us to hit the deadline) or there is clock shift. |
|
|
Implemented, just needs some testing with the UIs. |
|
|
Actually, still missing the automatic transition to expired without having to do confirmPay. |
|
|
Additional requirement requested by Marc: we should consider deleting expired transaction 24h after they've expired. |
|
|
commit b7b77db25f33bd675f3ee721376052dd1710b509 (HEAD -> master, origin/master, origin/HEAD) Author: Florian Dold <florian@dold.me> Date: Thu Mar 19 23:53:10 2026 +0100 wallet-core: automatically delete expired pay-merchant transactions after 24h commit e540862ac5ecf5b55ae9129f1b61e7ee01894f2f Author: Florian Dold <florian@dold.me> Date: Thu Mar 19 23:41:17 2026 +0100 wallet-core: automatically expire pay-merchant transactions |
|
|
Just needs a test now. |
|
|
commit 574d6ece737fc0722e0960f133f98c2dd294baa6 (HEAD -> master, origin/master, origin/HEAD) Author: Florian Dold <florian@dold.me> Date: Fri Mar 20 00:00:20 2026 +0100 harness: test for expired pay transactions in dialog state |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2024-11-12 13:27 | Florian Dold | New Issue | |
| 2024-11-12 13:27 | Florian Dold | Status | new => assigned |
| 2024-11-12 13:27 | Florian Dold | Assigned To | => Florian Dold |
| 2024-11-12 13:30 | Florian Dold | Note Added: 0023705 | |
| 2024-11-19 15:22 | Florian Dold | Note Added: 0023735 | |
| 2024-12-04 22:54 | Florian Dold | Assigned To | Florian Dold => MarcS |
| 2024-12-16 21:23 | Christian Grothoff | Target Version | 0.14 => 1.0 |
| 2025-04-18 15:28 | Christian Grothoff | Target Version | 1.0 => 1.0 stretch goals |
| 2025-05-26 10:46 | Florian Dold | Assigned To | MarcS => Florian Dold |
| 2025-05-26 10:47 | Florian Dold | Note Added: 0025000 | |
| 2025-06-05 01:55 | Florian Dold | Target Version | 1.0 stretch goals => 1.6 |
| 2025-06-05 14:06 | Florian Dold | Summary | wallet does not automatically handle expired pay-merchant transactions, payment-expired test also only handles manual case => wallet does not automatically handle expired pay-merchant transactions, payment-expired test also only handles manual case [6h] |
| 2025-08-31 19:35 | Christian Grothoff | Relationship added | parent of 0010066 |
| 2025-09-04 20:44 | Christian Grothoff | Target Version | 1.6 => 1.5 |
| 2026-03-12 13:21 | Florian Dold | Note Added: 0028117 | |
| 2026-03-19 23:44 | Florian Dold | Note Edited: 0028117 | |
| 2026-03-19 23:53 | Florian Dold | Note Added: 0028190 | |
| 2026-03-19 23:54 | Florian Dold | Note Added: 0028191 | |
| 2026-03-20 00:00 | Florian Dold | Note Added: 0028193 | |
| 2026-03-20 00:01 | Florian Dold | Status | assigned => resolved |
| 2026-03-20 00:01 | Florian Dold | Resolution | open => fixed |
