View Issue Details

IDProjectCategoryView StatusLast Update
0009313GNUnetotherpublic2024-11-14 09:43
ReporterEric E Assigned Toschanzen  
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Product Version0.22.2 
Target Version0.23.0 
Summary0009313: Multiple lines of Log output are missing newlines.
DescriptionI've installed gnunet 0.22.2 and have enable logging for debugging a problem with connecting to other peers, I'll submit another bug ticket for that problem later.

Checking the logs shows there are multiple lines of text that are missing the newline character, making reading the logs difficult. It is not for all lines, just some.

For example multiple warnings appear on the same line:

<TIMESTAMP> gnunet-communicator-tcp-26872 WARNING connect to `tcp-[fe80::216:3eff:fe80:b281]:2086' failed: Invalid argument<TIMESTAMP> gnunet-communicator-tcp-26872 WARNING connect to `tcp-[fd42:b6ed:28bd:aa::1]:2086' failed: Network is unreachable<TIMESTAMP> gnunet-communicator-tcp-26872 WARNING connect to `tcp-[fe80::ae1f:6bff:fe62:1765]:2086' failed: Invalid argument<TIMESTAMP> gnunet-communicator-tcp-26872 WARNING There is already a request reversal for `C7TD'at `tcp-210.10.76.126'

The output should look like this:
<TIMESTAMP> gnunet-communicator-tcp-26872 WARNING connect to `tcp-[fe80::216:3eff:fe80:b281]:2086' failed: Invalid argument
<TIMESTAMP> gnunet-communicator-tcp-26872 WARNING connect to `tcp-[fd42:b6ed:28bd:aa::1]:2086' failed: Network is unreachable
<TIMESTAMP> gnunet-communicator-tcp-26872 WARNING connect to `tcp-[fe80::ae1f:6bff:fe62:1765]:2086' failed: Invalid argument
<TIMESTAMP> gnunet-communicator-tcp-26872 WARNING There is already a request reversal for `C7TD'at `tcp-210.10.76.126'
Steps To ReproduceI've configured logging as below during the install process:

./configure --prefix=$GNUNET_PREFIX/.. --enable-logging=verbose 2>&1

I clear gnunet settings before starting gnunet:
$ rm -rf ~/.local/share/gnunet

Start gnunet
$ gnunet-arm -s

Check the logs:
tail ~/.cache/gnunet/gnunet-2024-11-02.log
Additional InformationINFO: gnunet-bugreport 0.11.0
=========================================
INFO: OS : Linux
INFO: OS RELEASE : 6.1.0-26-amd64
INFO: HARDWARE : x86_64
INFO: awk : Found
INFO: gcc : gcc (Debian 12.2.0-14) 12.2.0
INFO: cc : cc (Debian 12.2.0-14) 12.2.0
INFO: c++ : c++ (Debian 12.2.0-14) 12.2.0
INFO: clang :
INFO: clang++ :
WARNING: make : Not Found (unexpected result)
INFO: gmake : 4.3
INFO: autoconf : 2.71
INFO: automake : 1.16.5
INFO: libtool : 2.4.7
INFO: GNUnet : 0.22.2
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
INFO: git commit :
INFO: libgcrypt : 1.10.1
INFO: mysql : Not Found
INFO: pkgconf : 1.8.1
INFO: pkg-config : 1.8.1
INFO: glib2 : 2.74.6
INFO: GTK2 : Not found
INFO: GTK3 : Not found
INFO: GTK4 :
INFO: GMP : libgmp-dev-2:6.2.1+dfsg1-1.1.deb
INFO: libunistring : libunistring3-dev-1.0-2.deb
INFO: GNU gettext : 0.21
INFO: gettext : Found
INFO: libcurl : 7.88.1
INFO: libgnurl : Not found
WARNING: libgnurl or libcurl : Not found
INFO: libmicrohttpd : 97500
INFO: GNU GLPK : 5.0
INFO: GnuTLS : 3.7.9
TagsNo tags attached.

Activities

schanzen

2024-11-04 10:50

administrator   ~0023651

It is very good that you raised this issue. It irks me that our GNUNET_log calls do NOT incluide a newline at the end.
It makes _no_ sense, because logs are unreadable without it since we prepend all kinds of metadata before the message anyway.

What we should do is make GNUNET_log always appens a "\n"
Unfortunately, this will require is to remove the manually added "\n"'s from the existing messages, or automatically chop it somehow.

schanzen

2024-11-04 23:12

administrator   ~0023660

Fix committed to master branch.

Related Changesets

gnunet: master 0f8298dd

2024-11-05 00:11

schanzen


Details Diff
util: Modify logging behaviour to append newline if absent to prevent clobbering output. Fixes 0009313 Affected Issues
0009313
mod - src/lib/util/common_logging.c Diff File

Issue History

Date Modified Username Field Change
2024-11-02 05:18 Eric E New Issue
2024-11-03 20:34 schanzen Target Version => 0.22.3
2024-11-04 10:50 schanzen Note Added: 0023651
2024-11-04 10:50 schanzen Assigned To => Christian Grothoff
2024-11-04 10:50 schanzen Status new => assigned
2024-11-04 23:12 schanzen Changeset attached => gnunet master 0f8298dd
2024-11-04 23:12 schanzen Note Added: 0023660
2024-11-04 23:12 schanzen Assigned To Christian Grothoff => schanzen
2024-11-04 23:12 schanzen Status assigned => resolved
2024-11-04 23:12 schanzen Resolution open => fixed
2024-11-14 09:43 schanzen Target Version 0.22.3 => 0.23.0