View Issue Details

IDProjectCategoryView StatusLast Update
0009305GNUnetutil librarypublic2024-12-09 18:03
Reporterfefe Assigned Toschanzen  
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Target Version0.23.0Fixed in Version0.23.0 
Summary0009305: get_size_rec uses stat when it should be using lstat
Description   162 if (0 != stat (fn, &buf))
   163 {
   164 LOG_STRERROR_FILE (GNUNET_ERROR_TYPE_DEBUG, "stat", fn);
   165 return GNUNET_SYSERR;
   166 }

   173 if ((! S_ISLNK (buf.st_mode)) || (gfsd->include_sym_links == GNUNET_YES))
   174 gfsd->total += buf.st_size;

stat follows symlinks. S_ISLNK will never be true. If you want to stat the symlink instead of what it is pointing to, use lstat.
TagsNo tags attached.

Activities

schanzen

2024-11-03 20:33

administrator   ~0023642

Fix committed to master branch.

schanzen

2024-12-09 18:03

administrator   ~0023834

Released

Related Changesets

gnunet: master 4a6646a7

2024-11-03 21:33

schanzen


Details Diff
util: get_size_rec used stat when it should have used lstat. Fixes 0009305 Affected Issues
0009305
mod - src/lib/util/disk.c Diff File

Issue History

Date Modified Username Field Change
2024-11-01 12:30 fefe New Issue
2024-11-03 20:33 schanzen Changeset attached => gnunet master 4a6646a7
2024-11-03 20:33 schanzen Note Added: 0023642
2024-11-03 20:33 schanzen Assigned To => schanzen
2024-11-03 20:33 schanzen Status new => resolved
2024-11-03 20:33 schanzen Resolution open => fixed
2024-11-03 20:34 schanzen Target Version => 0.22.3
2024-11-14 09:43 schanzen Target Version 0.22.3 => 0.23.0
2024-12-09 18:03 schanzen Fixed in Version => 0.23.0
2024-12-09 18:03 schanzen Note Added: 0023834
2024-12-09 18:03 schanzen Status resolved => closed