View Issue Details

IDProjectCategoryView StatusLast Update
0009213Talerwallet-corepublic2024-10-07 16:35
Reportersebasjm Assigned ToFlorian Dold  
PriorityhighSeveritymajorReproducibilityalways
Status resolvedResolutionfixed 
Product Version0.14 
Target Version0.14Fixed in Version0.14 
Summary0009213: payment transactions should automatically abort when the merchant has KYC problems [2h]
DescriptionI would say that this should be permanent failure for now, but this is not good enough, an awful scenario will be:
1.- me trying to buy from (A) some beer for 5 EUR, I have 10 EUR from (B) 's exchange and 10 EUR from (C) 's exchange
2.- (A) didn't make KYC agaist (B) 's exchange, and my wallet used (B) coins so i won't be ableto drink my beer :(
3.- now comes (D) which is just have 10 EUR from (C) 's exchange and drink in front of me :(

right now we have this problems:
1.- the ugly error message
2.- I lost my money because of avalos, can't get it back
3.- i was unable to buy EVEN if I have the money for it, and (D) doesn't share it with me
 
TagsNo tags attached.

Activities

sebasjm

2024-09-23 18:35

developer   ~0023354

> 2.- I lost my money because of avalos, can't get it back

transaction is in error state, but after aborting the wallet recover the coins.
I see no reason to automatically abort the transaction so wallet user gets it's money back automatically.
otherwise
1.- exchange have the money, wallet user can't use it with other merchants
2.- merchant usually should not fall into blocked operation by deposit-kyc, this is not normal
3.- kyc process usually are not instant, it's going to take a while for the operation to succeed

> 1.- the ugly error message

aborted tx should include a flag indicating "aborted because kyc deposit by the merchant"
this could potentially help the wallet user and merchant to solve the issue inplace

> 3.- i was unable to buy EVEN if I have the money for it, and (c) doesn't share it with me

maybe in the future we can automatically retry with other exchange with the same order

Florian Dold

2024-09-24 12:52

manager   ~0023363

commit ca516cd0906f28e11e88281398786738ab86530a (HEAD -> master, origin/master, origin/HEAD)
Author: Florian Dold <florian@dold.me>
Date: Tue Sep 24 12:51:46 2024 +0200

    wallet-core: auto-abort payments when merchant has KYC problems

Issue History

Date Modified Username Field Change
2024-09-23 16:59 sebasjm New Issue
2024-09-23 16:59 sebasjm Status new => assigned
2024-09-23 16:59 sebasjm Assigned To => Florian Dold
2024-09-23 18:35 sebasjm Note Added: 0023354
2024-09-23 18:37 sebasjm Description Updated
2024-09-24 11:24 Florian Dold Summary failed when paying and the merhcant has kyc problems => payment transactions should automatically abort when the merchant has KYC problems
2024-09-24 11:24 Florian Dold Summary payment transactions should automatically abort when the merchant has KYC problems => payment transactions should automatically abort when the merchant has KYC problems [2h]
2024-09-24 12:52 Florian Dold Note Added: 0023363
2024-09-24 12:52 Florian Dold Status assigned => resolved
2024-09-24 12:52 Florian Dold Resolution open => fixed
2024-10-07 16:35 Christian Grothoff Fixed in Version => 0.14