View Issue Details

IDProjectCategoryView StatusLast Update
0009159Talerwallet (Android App)public2024-09-17 16:10
Reportermikolai Assigned Toavalos  
PrioritynormalSeveritymajorReproducibilityalways
Status feedbackResolutionopen 
Product Version0.12 
Target Version0.14 
Summary0009159: Pending deposit to bank account cannot be cancelled
DescriptionAfter initiating a deposit to a bank account, it is shown as PENDING and on the details page, there is a button to cancel the transaction. Clicking that opens a pop-up dialog where I can confirm the cancellation.

After confirming, the screen looks exactly as before and the transaction does not seem to be actually cancelled.
Steps To Reproduce1. use exchange.demo.taler.net
2. send money to a bank account with a valid IBAN (I just picked one at random from bank.demo.taler.net)
3. see the pending transaction in the list
4. click on the transaction
5. click on "cancel transaction" and confirm
6. see that nothing changes (except that the KUDOS-symbol is replaced by the literal name for some reason?)
TagsNo tags attached.

Activities

avalos

2024-09-05 21:40

developer   ~0023193

Either this is a wallet-core issue, or it was already fixed in master.
Can you reproduce on master?

commit aa95b912410e6a97b9def4a8e6d045b3c32fb687
Author: Iván Ávalos <avalos@disroot.org>
Date: Fri Aug 30 10:55:48 2024 +0200

    [wallet] move selected transition updates to separate function and always ensure updates

mikolai

2024-09-06 07:07

developer   ~0023198

I just reproduced with the nightly build from yesterday, I still have the same issue.

I used the bank account DE6305859669992 with the Account Holder "Test" (probably not matching the name on bank.demo.taler.net) and transfered 0.01 KUDOS.

Florian Dold

2024-09-12 11:44

manager   ~0023263

fdold-work@sapota ~/r/t/wallet-core (master)> git show --shortstat
commit c1c0603b3a3684c541e22f55e83323a795f134eb (HEAD -> master, origin/master, origin/HEAD)
Author: Florian Dold <florian@dold.me>
Date: Thu Sep 12 11:43:49 2024 +0200

    wallet-core: support abort/fail in new deposit states

 2 files changed, 36 insertions(+), 17 deletions(-)

Florian Dold

2024-09-12 11:44

manager   ~0023264

@Ivan: Please test / tag / deploy on Android!

avalos

2024-09-12 20:29

developer   ~0023274

It doesn't seem to work with the latest commit. :\

It worked with a deposit in error state, though.

Florian Dold

2024-09-17 16:09

manager   ~0023319

commit ac8c6682a5a3ef70f82f28af827c450a1fdb0830 (HEAD -> master, origin/master, origin/HEAD)
Author: Florian Dold <florian@dold.me>
Date: Tue Sep 17 16:07:20 2024 +0200

    wallet-core: fix deposit state machine
    
    When a deposit transaction is in pending(track), it can only be failed,
    not aborted. While the deposit is being tracked, it can still fail (due
    to KYC). That would result in lost funds, thus the only available
    option is fail.

Florian Dold

2024-09-17 16:10

manager   ~0023320

See the commit above: Actually, in the state pending(track), only failing the transaction should be possible, not aborting it.

Issue History

Date Modified Username Field Change
2024-09-03 13:36 mikolai New Issue
2024-09-03 13:36 mikolai Status new => assigned
2024-09-03 13:36 mikolai Assigned To => avalos
2024-09-04 10:02 Christian Grothoff Target Version => 0.14
2024-09-05 21:40 avalos Note Added: 0023193
2024-09-06 07:07 mikolai Note Added: 0023198
2024-09-11 18:38 Florian Dold Assigned To avalos => Florian Dold
2024-09-12 11:44 Florian Dold Note Added: 0023263
2024-09-12 11:44 Florian Dold Note Added: 0023264
2024-09-12 11:44 Florian Dold Assigned To Florian Dold => avalos
2024-09-12 20:29 avalos Note Added: 0023274
2024-09-13 11:35 avalos Status assigned => feedback
2024-09-13 11:48 avalos Assigned To avalos => Florian Dold
2024-09-17 16:09 Florian Dold Assigned To Florian Dold => avalos
2024-09-17 16:09 Florian Dold Note Added: 0023319
2024-09-17 16:10 Florian Dold Note Added: 0023320