View Issue Details

IDProjectCategoryView StatusLast Update
0008987Talermerchant backoffice SPApublic2024-09-17 16:29
Reporteravalos Assigned Tosebasjm  
PriorityhighSeverityminorReproducibilityunable to reproduce
Status closedResolutionfixed 
Product Versiongit (master) 
Target Version0.14Fixed in Version0.14 
Summary0008987: When adding a product, using a fractional number results in a validation error
DescriptionWhen you create a product in the merchant backend and use fractional numbers for the amount, when you press the "enter" button inside the amount field you get a validation error, and the uploaded image of the product disappears, then, when you correct the price to an integer number and you want to upload the image again, the upload button doesn't do anything.

Video: https://nextcloud.avalos.me/index.php/s/S2eXWBEy5L2cdKc
TagsNo tags attached.

Activities

nullptrderef

2024-08-04 22:54

developer   ~0022909

Last edited: 2024-08-04 23:05

Cannot reproduce on master (https://backend.head.taler.net) - is this still an issue?

see: https://files.catbox.moe/b8s6ca.mp4

avalos

2024-08-05 16:14

developer   ~0022922

Of course, keypresses are not visible on the screen recording, so, did you press enter inside the amount field after typing 0.5? That seemed to trigger the issue.

nullptrderef

2024-08-20 11:16

developer   ~0023011

Last edited: 2024-08-20 11:16

> Of course, keypresses are not visible on the screen recording, so, did you press enter inside the amount field after typing 0.5? That seemed to trigger the issue.
nope, can reproduce it now - appears to be due to https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/step#min_impact_on_step

fixed in 02fadc83b997e4f5175d0dcd91ab925cebb08f47, see if still reproducible

avalos

2024-08-30 09:53

developer   ~0023114

I can't reproduce anymore, however, if I now press enter in any text field other than the description one (which is multi-line), the file chooser dialog for selecting the image pops up.

nullptrderef

2024-09-15 00:31

developer   ~0023292

^ appears to have already been a bug - some weird things i don't quite understand cause it to press the first button in the DOM at enter time; removing the `Add` button will trigger it to press `Manage Stock` instead

this also happens for the 'Unit name' field which wouldn't have been affected by 02fadc83b997e4f5175d0dcd91ab925cebb08f47

Christian Grothoff

2024-09-16 14:19

manager   ~0023299

I would like to package the merchant 0.14 today or tomorrow for Datenspuren.de-event. Is this quickly fixable?

sebasjm

2024-09-16 17:27

developer   ~0023303

11233f014..a08d5dd17

image unload: added a workaround, the form will trigger the first button that it found and in this case is the InputImage button.

loading image 1, unloading and then loading image 1 again: it won't load since it won't trigger onChange action. This was fix updating the input element's value field when unloading the image.

Issue History

Date Modified Username Field Change
2024-06-27 00:34 avalos New Issue
2024-06-27 00:34 avalos Status new => assigned
2024-06-27 00:34 avalos Assigned To => sebasjm
2024-07-28 22:07 Christian Grothoff Target Version => 0.14
2024-08-04 21:12 Christian Grothoff Assigned To sebasjm => nullptrderef
2024-08-04 22:54 nullptrderef Note Added: 0022909
2024-08-04 22:56 nullptrderef Status assigned => feedback
2024-08-04 22:56 nullptrderef Reproducibility have not tried => unable to reproduce
2024-08-04 22:58 nullptrderef Note Edited: 0022909
2024-08-04 23:05 nullptrderef Note Edited: 0022909
2024-08-05 13:05 Christian Grothoff Assigned To nullptrderef => avalos
2024-08-05 16:14 avalos Note Added: 0022922
2024-08-20 11:16 nullptrderef Note Added: 0023011
2024-08-20 11:16 nullptrderef Note Edited: 0023011
2024-08-30 09:53 avalos Note Added: 0023114
2024-08-30 09:53 avalos File Added: Screenshot 2024-08-30 at 9.53.09 AM.png
2024-09-09 09:59 Christian Grothoff Assigned To avalos => nullptrderef
2024-09-09 09:59 Christian Grothoff Status feedback => assigned
2024-09-14 00:59 Christian Grothoff Priority low => high
2024-09-14 00:59 Christian Grothoff Product Version => git (master)
2024-09-15 00:31 nullptrderef Note Added: 0023292
2024-09-15 00:35 nullptrderef Assigned To nullptrderef => sebasjm
2024-09-16 14:19 Christian Grothoff Note Added: 0023299
2024-09-16 17:27 sebasjm Status assigned => resolved
2024-09-16 17:27 sebasjm Resolution open => fixed
2024-09-16 17:27 sebasjm Note Added: 0023303
2024-09-16 17:34 Christian Grothoff Fixed in Version => 0.14
2024-09-17 16:29 Christian Grothoff Status resolved => closed