View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0008806 | GNUnet | build process | public | 2024-05-07 04:44 | 2024-06-08 12:03 |
| Reporter | ulfvonbelow | Assigned To | schanzen | ||
| Priority | normal | Severity | trivial | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Platform | x86-64 | OS | Guix System | OS Version | a1d711c92e |
| Product Version | Git master | ||||
| Fixed in Version | 0.21.2 | ||||
| Summary | 0008806: ./bootstrap fails when ./.git doesn't exist | ||||
| Description | bootstrap attempts to unconditionally install hooks, which causes the script to fail when .git doesn't exist, as it may not in cases where a checkout has been scrubbed of the version control information to save space. | ||||
| Steps To Reproduce | mv .git .git-tmp ./bootstrap echo $? | ||||
| Additional Information | This is primarily an issue in automated builds. Patch attached. | ||||
| Tags | No tags attached. | ||||
| Attached Files | 0001-build-system-only-try-installing-hooks-if-.git-direc.patch (585 bytes)
From 290d6ae81b63f46f57a89e3f13e2124c1cef3e5a Mon Sep 17 00:00:00 2001
From: ulfvonbelow <striness@tilde.club>
Date: Fri, 3 May 2024 21:50:11 -0500
Subject: [PATCH] build system: only try installing hooks if .git directory
exists.
---
bootstrap | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/bootstrap b/bootstrap
index d5bf30af4..fb47649a7 100755
--- a/bootstrap
+++ b/bootstrap
@@ -136,7 +136,10 @@ main()
check_libtool
fi
pogen
- install_hooks
+ if test -d .git
+ then
+ install_hooks
+ fi
}
main "$@"
--
2.41.0
| ||||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2024-05-07 04:44 | ulfvonbelow | New Issue | |
| 2024-05-07 04:44 | ulfvonbelow | File Added: 0001-build-system-only-try-installing-hooks-if-.git-direc.patch | |
| 2024-05-13 10:43 | schanzen | Assigned To | => schanzen |
| 2024-05-13 10:43 | schanzen | Status | new => resolved |
| 2024-05-13 10:43 | schanzen | Resolution | open => fixed |
| 2024-05-13 10:43 | schanzen | Fixed in Version | => 0.21.2 |
| 2024-05-13 10:43 | schanzen | Note Added: 0022389 | |
| 2024-06-08 12:03 | schanzen | Note Added: 0022539 | |
| 2024-06-08 12:03 | schanzen | Status | resolved => closed |
