View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0007987 | Taler | libeufin-bank | public | 2023-11-21 07:26 | 2023-12-02 12:01 |
Reporter | MS | Assigned To | Antoine A | ||
Priority | normal | Severity | minor | Reproducibility | have not tried |
Status | assigned | Resolution | open | ||
Target Version | 0.9.6 | ||||
Summary | 0007987: Make TalerCommon.kt HTTP- and bank-agostic and move it into util | ||||
Description | TalerCommon.kt has useful logic also for Nexus. One example is the one to manipulate amounts. However, TalerCommon.kt depends a lot on HTTP-definitions, like it throws "bad request" if the parser fails. The util module should instead be as protocol-agnostic as possible, and try to avoid HTTP or bank/nexus-specific definitions as much as possible: the way to fail is then decided by the caller application. TalerCommon.kt does not even only depend on HTTP, but also on *bank* specific definitions, like LibeufinBankException and several GANA errors like BANK_BAD_FORMAT_AMOUNT. That does not belong to util, where other non-bank applications may accidentally import and throw such errors. | ||||
Tags | No tags attached. | ||||
Date Modified | Username | Field | Change |
---|---|---|---|
2023-11-21 07:26 | MS | New Issue | |
2023-11-21 07:26 | MS | Status | new => assigned |
2023-11-21 07:26 | MS | Assigned To | => MS |
2023-11-21 07:27 | MS | Description Updated | |
2023-11-21 07:27 | MS | Assigned To | MS => |
2023-12-02 11:54 | Christian Grothoff | Target Version | => 0.9.6 |
2023-12-02 12:01 | Christian Grothoff | Assigned To | => Antoine A |