View Issue Details

IDProjectCategoryView StatusLast Update
0007987Talerlibeufin-bankpublic2024-03-07 20:49
ReporterMS Assigned ToAntoine A  
PrioritynormalSeveritytrivialReproducibilityhave not tried
Status closedResolutionfixed 
Target Version0.9.4Fixed in Version0.9.4 
Summary0007987: Make TalerCommon.kt HTTP- and bank-agostic and move it into util
DescriptionTalerCommon.kt has useful logic also for Nexus. One example is the one to manipulate amounts. However, TalerCommon.kt depends a lot on HTTP-definitions, like it throws "bad request" if the parser fails. The util module should instead be as protocol-agnostic as possible, and try to avoid HTTP or bank/nexus-specific definitions as much as possible: the way to fail is then decided by the caller application.

TalerCommon.kt does not even only depend on HTTP, but also on *bank* specific definitions, like LibeufinBankException and several GANA errors like BANK_BAD_FORMAT_AMOUNT. That does not belong to util, where other non-bank applications may accidentally import and throw such errors.

TagsNo tags attached.


There are no notes attached to this issue.

Issue History

Date Modified Username Field Change
2023-11-21 07:26 MS New Issue
2023-11-21 07:26 MS Status new => assigned
2023-11-21 07:26 MS Assigned To => MS
2023-11-21 07:27 MS Description Updated
2023-11-21 07:27 MS Assigned To MS =>
2023-12-02 11:54 Christian Grothoff Target Version => 0.11
2023-12-02 12:01 Christian Grothoff Assigned To => Antoine A
2023-12-22 14:17 Christian Grothoff Severity minor => trivial
2023-12-22 14:17 Christian Grothoff Target Version 0.11 => post-1.0
2024-01-24 15:20 Antoine A Status assigned => resolved
2024-01-24 15:20 Antoine A Resolution open => fixed
2024-01-27 01:14 Christian Grothoff Fixed in Version => 0.9.4
2024-01-27 01:14 Christian Grothoff Target Version post-1.0 => 0.9.4
2024-03-07 20:49 Christian Grothoff Status resolved => closed