View Issue Details

IDProjectCategoryView StatusLast Update
0007969Talerwallet-corepublic2023-11-29 01:30
ReporterMarcS Assigned ToFlorian Dold  
PriorityhighSeveritymajorReproducibilityhave not tried
Status closedResolutionfixed 
Product Version0.9.4 
Target Version0.9.3Fixed in Version0.9.3 
Summary0007969: When the server is down, wallet-core shouldn't throw a JSON error from downloadExchangeKeysInfo
DescriptionPossibly unhandled promise rejection: Error: Couldn't parse JSON format from error response
    at TalerError (/Users/ms/Developer/gnuTaler/quickjs-tart/taler-wallet-core-qjs.mjs:12095)
    at fromDetail (/Users/ms/Developer/gnuTaler/quickjs-tart/taler-wallet-core-qjs.mjs:12104)
    at readTalerErrorResponse (/Users/ms/Developer/gnuTaler/quickjs-tart/taler-wallet-core-qjs.mjs:12471)
    at readSuccessResponseJsonOrErrorCode (/Users/ms/Developer/gnuTaler/quickjs-tart/taler-wallet-core-qjs.mjs:12515)
    at readSuccessResponseJsonOrThrow (/Users/ms/Developer/gnuTaler/quickjs-tart/taler-wallet-core-qjs.mjs:12561)
    at downloadExchangeKeysInfo (/Users/ms/Developer/gnuTaler/quickjs-tart/taler-wallet-core-qjs.mjs:25907)
TagsNo tags attached.


Florian Dold

2023-11-14 13:57

manager   ~0020640

Not sure what we should do here, as the server *gives* us a response, and it's not valid JSON. The server (exchange) is down, but the reverse proxy (nginx) still gives us a valid HTTP response.

I guess we could be stricter with the response handling: If the response headers don't indicate it's JSON, we don't parse it and instead report that the server did not even respond with JSON.

@MarcS: Would that fix this bug for you or do you think something entirely different should happen here?

Florian Dold

2023-11-21 11:52

manager   ~0020653

Fixed in wallet-core.git:342df60a.

We now give a better error message when the error response didn't even contain JSON.

Issue History

Date Modified Username Field Change
2023-10-26 14:50 MarcS New Issue
2023-10-26 14:50 MarcS Status new => assigned
2023-10-26 14:50 MarcS Assigned To => Florian Dold
2023-11-14 13:57 Florian Dold Status assigned => feedback
2023-11-14 13:57 Florian Dold Note Added: 0020640
2023-11-14 14:00 Florian Dold Assigned To Florian Dold => MarcS
2023-11-15 12:11 Florian Dold Assigned To MarcS => Florian Dold
2023-11-21 11:52 Florian Dold Status feedback => resolved
2023-11-21 11:52 Florian Dold Resolution open => fixed
2023-11-21 11:52 Florian Dold Note Added: 0020653
2023-11-29 01:28 Christian Grothoff Target Version 0.9.4 => 0.9.3
2023-11-29 01:29 Christian Grothoff Fixed in Version => 0.9.3
2023-11-29 01:30 Christian Grothoff Status resolved => closed