View Issue Details

IDProjectCategoryView StatusLast Update
0007750Talerexchangepublic2023-09-23 15:09
ReporterMS Assigned ToMS  
PriorityhighSeverityminorReproducibilityhave not tried
Status closedResolutionno change required 
Target Version0.9.3Fixed in Version0.9.3 
Summary0007750: taler-exchange-wirewatch ignores the -f option
DescriptionThat causes requests to Nexus /history/incoming to lack the long_poll_ms parameter.
TagsNo tags attached.


Christian Grothoff

2023-03-07 21:20

manager   ~0019927

I've inspected the code (visually), and it seems to CLEARLY set the timeout, except for two key cases:
1) if we are in test-mode (-t), and
2) if we are going backwards in time

In both cases, using the timeout makes no sense and is correctly disabled. How exactly are you calling taler-exchange-wirewatch to conclude that '-f' is not respected?


2023-03-08 14:27

reporter   ~0019934

with -t. Why is that disabled? What if users want to check that both client and server respect the timeout?

Christian Grothoff

2023-03-08 14:29

manager   ~0019935

-t is test-mode, where the service is supposed to exit when no more work is available, not "hang around". So long polling doesn't make sense in test-mode.


2023-03-08 14:39

reporter   ~0019936

Also, the help message is unclear about the unit of time being expected by -f. Below is the relevant --help part:

  -f, --longpoll-timeout=DELAY
                             what is the timeout when asking the bank about
                               new transactions

After some tries, it seems that -f N translates to a long_poll_ms of N/1000.

This command:
$ taler-exchange-wirewatch -c wirewatch.conf -L DEBUG -f 100000

Causes this request:
GET /facades/test-facade/taler-wire-gateway/history/incoming?delta=1024&long_poll_ms=100

Is that intentional?

Christian Grothoff

2023-03-08 14:49

manager   ~0019937

Last edited: 2023-03-08 14:50

Yes. Note that you probably want to use

$ taler-exchange-wirewatch -c wirewatch.conf -L DEBUG -f "100 ms"
$ taler-exchange-wirewatch -c wirewatch.conf -L DEBUG -f "30 s"

etc, just like we usually do when passing time values. Without any unit, it is microseconds and hence correctly divided by 1000.


2023-04-11 19:15

reporter   ~0020075

Ack. for the clarification and yes, without "-t" wirewatch sends the long_poll_ms parameter.

Issue History

Date Modified Username Field Change
2023-03-07 18:18 MS New Issue
2023-03-07 18:18 MS Status new => assigned
2023-03-07 18:18 MS Assigned To => Christian Grothoff
2023-03-07 18:18 MS Priority normal => high
2023-03-07 21:20 Christian Grothoff Note Added: 0019927
2023-03-07 21:20 Christian Grothoff Assigned To Christian Grothoff => MS
2023-03-07 21:20 Christian Grothoff Status assigned => feedback
2023-03-08 14:27 MS Note Added: 0019934
2023-03-08 14:29 Christian Grothoff Note Added: 0019935
2023-03-08 14:39 MS Note Added: 0019936
2023-03-08 14:49 Christian Grothoff Note Added: 0019937
2023-03-08 14:50 Christian Grothoff Note Edited: 0019937
2023-04-04 15:58 Florian Dold Target Version => 0.9.3
2023-04-11 19:15 MS Note Added: 0020075
2023-04-11 19:16 MS Status feedback => resolved
2023-04-11 19:16 MS Resolution open => no change required
2023-09-23 15:07 Christian Grothoff Fixed in Version => 0.9.3
2023-09-23 15:09 Christian Grothoff Status resolved => closed