View Issue Details

IDProjectCategoryView StatusLast Update
0007749Talerwallet-corepublic2023-09-23 15:09
ReporterFlorian Dold Assigned Tosebasjm  
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Target Version0.9.3Fixed in Version0.9.3 
Summary0007749: wallet-core should forward offline payment TOTP to UIs
DescriptionSee summary.
TagsNo tags attached.

Activities

Florian Dold

2023-04-21 12:41

manager   ~0020123

Sebastian already implemented it in wallet-core. Is it also supported in the UI? I also wonder if we should have an integration test.

sebasjm

2023-04-24 19:53

developer   ~0020142

fixed at 974cd0206

sebasjm

2023-04-24 19:53

developer   ~0020143

Selection_086.png (41,596 bytes)   
Selection_086.png (41,596 bytes)   

sebasjm

2023-04-24 19:57

developer   ~0020144

the list of numbers is serialized by the merchant to a string separated by \n
this is not standard

comma separated is better or maybe just a simple array of numbers instead of string

https://docs.taler.net/core/api-merchant.html#post-[-instances-$INSTANCE]-orders-$ORDER_ID-pay

Christian Grothoff

2023-04-24 20:01

manager   ~0020145

Last edited: 2023-04-24 20:02

I'm not sure what you mean by "is not standard". First of all, we do not guarantee that this is an array, or even numbers.
The idea is (for now) that this is the "text to show", and that if it has newlines, you should render it with newlines! These are 5 TOTP
codes, and the idea is that the POS staff should match any single one of them. So I don't see why comma vs \n would be any better, or more "standard". My goal was to give it to you in exactly the format that you could just directly give to a rendering engine.

Oh, and you should NOT render them in one long line, that's not the intended format here. The idea was to show one code per line on 3-5 lines.

sebasjm

2023-04-24 20:48

developer   ~0020147

Last edited: 2023-04-24 22:52

> Oh, and you should NOT render them in one long line, that's not the intended format here. The idea was to show one code per line on 3-5 lines.

That's how the render engine is showing it, I will add a < pre > so the browser will render the \n

> I'm not sure what you mean by "is not standard"
For clarification: I meant a standard way of showing a list of numbers, people can understand a comma separated value and it will show exactly the same way everywhere.

\n may not be rendered in the same way in html or in a cli using linux or windows.

sebasjm

2023-04-24 23:00

developer   ~0020150

2f8de9ea86cc1170b45e13fae6f0a66c7c4fd038 added
	

Issue History

Date Modified Username Field Change
2023-03-07 18:16 Florian Dold New Issue
2023-03-07 18:16 Florian Dold Status new => assigned
2023-03-07 18:16 Florian Dold Assigned To => Florian Dold
2023-03-08 13:41 Florian Dold Summary wallet-core should forward offline payment TOTP to UIS => wallet-core should forward offline payment TOTP to UIs
2023-04-13 20:36 Florian Dold Category wallet (TS core) => wallet-core
2023-04-21 12:40 Florian Dold Assigned To Florian Dold => sebasjm
2023-04-21 12:41 Florian Dold Note Added: 0020123
2023-04-24 19:53 sebasjm Note Added: 0020142
2023-04-24 19:53 sebasjm Note Added: 0020143
2023-04-24 19:53 sebasjm File Added: Selection_086.png
2023-04-24 19:57 sebasjm Note Added: 0020144
2023-04-24 19:57 sebasjm Assigned To sebasjm => Christian Grothoff
2023-04-24 19:57 sebasjm Status assigned => feedback
2023-04-24 20:01 Christian Grothoff Note Added: 0020145
2023-04-24 20:02 Christian Grothoff Note Edited: 0020145
2023-04-24 20:02 Christian Grothoff Assigned To Christian Grothoff => sebasjm
2023-04-24 20:02 Christian Grothoff Status feedback => assigned
2023-04-24 20:48 sebasjm Note Added: 0020147
2023-04-24 22:52 sebasjm Note Edited: 0020147
2023-04-24 23:00 sebasjm Status assigned => resolved
2023-04-24 23:00 sebasjm Resolution open => fixed
2023-04-24 23:00 sebasjm Note Added: 0020150
2023-09-23 15:07 Christian Grothoff Fixed in Version => 0.9.3
2023-09-23 15:09 Christian Grothoff Status resolved => closed