View Issue Details

IDProjectCategoryView StatusLast Update
0007747Talerexchangepublic2023-09-23 15:09
ReporterFlorian Dold Assigned ToChristian Grothoff  
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Target Version0.9.3Fixed in Version0.9.3 
Summary0007747: sample exchange ToS HTML is giant
DescriptionFor some reason, the ToS converted to HTML is unacceptable large (>600KB), when it is just simple, plain text.

It is so large, that it doesn't fit into one Android IPC message (with JSON encoding/escaping overhead)
TagsNo tags attached.


Christian Grothoff

2023-03-07 13:17

manager   ~0019924

Why does the Android wallet request the HTML version? It is so huge as it packs various JS+CSS to make it render nicely. The Android wallet should be asking for RST or TXT, not HTML!

Florian Dold

2023-03-28 20:20

manager   ~0019985

One issue is that the exchange returns the giant HTML response *by default*, either when no "Accept:" header is specified, or there is no match for the requested content type.

But I currently don't understand why wallet-core is not requesting either "text/plain" or "text/markdown", I'll have to look into this.

Florian Dold

2023-03-29 21:01

manager   ~0019989

Okay, so I've fixed a bug in qtart that caused *duplicate* "Accept: application/json" and "Accept: text/plain" headers to be added, which was clearly wrong.

However, I still think it's bad behavior of the exchange to default to returning HTML when there is no matching ToS for the requested MIME type or no Accept header was given.

Christian Grothoff

2023-03-30 03:11

manager   ~0019991

Well, what do you think should be the default? HTML is usually the default for the Web, but I guess we could default to text/plain as well...

Christian Grothoff

2023-04-08 09:46

manager   ~0020039

cbabddf0..677ac4a5 changes the default to text/plain.

Issue History

Date Modified Username Field Change
2023-03-07 13:13 Florian Dold New Issue
2023-03-07 13:13 Florian Dold Status new => assigned
2023-03-07 13:13 Florian Dold Assigned To => Christian Grothoff
2023-03-07 13:17 Christian Grothoff Note Added: 0019924
2023-03-07 13:17 Christian Grothoff Assigned To Christian Grothoff => Florian Dold
2023-03-07 13:17 Christian Grothoff Status assigned => feedback
2023-03-28 20:20 Florian Dold Note Added: 0019985
2023-03-29 21:01 Florian Dold Assigned To Florian Dold => Christian Grothoff
2023-03-29 21:01 Florian Dold Status feedback => assigned
2023-03-29 21:01 Florian Dold Note Added: 0019989
2023-03-30 03:11 Christian Grothoff Note Added: 0019991
2023-04-08 09:46 Christian Grothoff Note Added: 0020039
2023-04-08 09:46 Christian Grothoff Status assigned => resolved
2023-04-08 09:46 Christian Grothoff Resolution open => fixed
2023-04-08 09:46 Christian Grothoff Fixed in Version => 0.9.3
2023-09-23 15:09 Christian Grothoff Status resolved => closed