View Issue Details

IDProjectCategoryView StatusLast Update
0007728Talerwallet (Android App)public2023-09-23 15:09
ReporterFlorian Dold Assigned Toavalos  
PriorityhighSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Target Version0.9.3Fixed in Version0.9.3 
Summary0007728: "confirm with bank" button stays in transaction history even when withdrawal is complete
DescriptionSomething is not updated correctly here.
TagsNo tags attached.



2023-02-28 17:15

developer   ~0019910

What do you mean by “transaction history”? The transactions list? As far as I know, the “confirm with bank” button hasn't been merged there yet. Currently, it is only present in the transaction details.


2023-02-28 17:20

developer   ~0019911

Nevermind, the “confirm with bank” button was already merged. However, there's a pending refactoring of the button. Now I'm using a Jetpack composable for the button, and it has improved logic.


2023-02-28 17:35

developer   ~0019912

I can confirm that the new composable action button is updating correctly.


2023-03-21 22:18

developer   ~0019974

@avalos do we need to merge anything to resolve this? Are composable versions of this button strictly needed for the fix?

@florian I remember that Christian wasn't so keen on having that button in the transaction list at all. Maybe easier to just remove it?

Florian Dold

2023-04-04 18:26

manager   ~0020016

Decided today on Mumble: We leave out the button in the transaction list. Instead we show a badge, ideally based on the state and substate when DD37 support is available in wallet-core.


2023-04-10 08:39

developer   ~0020043

I removed the action button from the transaction list in dev/ivan-avalos/master, please give it a check. I still think it would be a good idea to put the composable action button in the transaction details, as it has a more flexible handling of user actions, and it won't affect performance noticeably in the release version, as things are significantly optimized.


2023-04-10 22:45

developer   ~0020057

Buttons was removed in c2283c02428005a8ce0dc00df72535e27f7892d9

Issue History

Date Modified Username Field Change
2023-02-24 19:58 Florian Dold New Issue
2023-02-24 19:58 Florian Dold Status new => assigned
2023-02-24 19:58 Florian Dold Assigned To => avalos
2023-02-28 17:15 avalos Note Added: 0019910
2023-02-28 17:20 avalos Note Added: 0019911
2023-02-28 17:35 avalos Note Added: 0019912
2023-03-21 22:18 grote Note Added: 0019974
2023-04-04 18:26 Florian Dold Note Added: 0020016
2023-04-10 08:39 avalos Note Added: 0020043
2023-04-10 22:45 grote Status assigned => resolved
2023-04-10 22:45 grote Resolution open => fixed
2023-04-10 22:45 grote Note Added: 0020057
2023-09-23 15:07 Christian Grothoff Fixed in Version => 0.9.3
2023-09-23 15:09 Christian Grothoff Status resolved => closed