|
|
What do you mean by “transaction history”? The transactions list? As far as I know, the “confirm with bank” button hasn't been merged there yet. Currently, it is only present in the transaction details. |
|
|
|
Nevermind, the “confirm with bank” button was already merged. However, there's a pending refactoring of the button. Now I'm using a Jetpack composable for the button, and it has improved logic. |
|
|
|
I can confirm that the new composable action button is updating correctly. |
|
|
|
@avalos do we need to merge anything to resolve this? Are composable versions of this button strictly needed for the fix?
@florian I remember that Christian wasn't so keen on having that button in the transaction list at all. Maybe easier to just remove it? |
|
|
|
Decided today on Mumble: We leave out the button in the transaction list. Instead we show a badge, ideally based on the state and substate when DD37 support is available in wallet-core. |
|
|
|
I removed the action button from the transaction list in dev/ivan-avalos/master, please give it a check. I still think it would be a good idea to put the composable action button in the transaction details, as it has a more flexible handling of user actions, and it won't affect performance noticeably in the release version, as things are significantly optimized. |
|
|
|
Buttons was removed in c2283c02428005a8ce0dc00df72535e27f7892d9 |
|
