View Issue Details

IDProjectCategoryView StatusLast Update
0007618GNUnetutil librarypublic2023-06-01 20:26
Reporterulfvonbelow Assigned Toschanzen  
PrioritynormalSeverityminorReproducibilityN/A
Status closedResolutionfixed 
Product VersionGit master 
Target Version0.19.4Fixed in Version0.19.4 
Summary0007618: Typo (?) in GNUNET_CONTAINER_MulitHashMapIteratorCallback
Descriptions/Mulit/Multi/g.
Steps To ReproduceRead code carefully. See typo. Be distracted.
Additional InformationPatch attached.

Only those bearing mullets are allowed to use mulit henceforth.
Tagspatch
Attached Files
0001-INCLUDE-change-Mulit-Multi-in-G_C_MulitHashMapIterat.patch (6,312 bytes)   
From fc89a8866aca00dc5a54171114aa98dc0f000660 Mon Sep 17 00:00:00 2001
From: ulfvonbelow <strilen@tilde.club>
Date: Sat, 28 Jan 2023 16:35:42 -0600
Subject: [PATCH] INCLUDE: change Mulit --> Multi in
 G_C_MulitHashMapIteratorCallback.

I don't know how this went either unnoticed or unchanged. Is it a
compatibility thing?
---
 src/fs/gnunet-service-fs_pr.c       |  2 +-
 src/include/gnunet_container_lib.h  | 14 +++++++-------
 src/set/gnunet-set-ibf-profiler.c   |  2 +-
 src/setu/gnunet-setu-ibf-profiler.c |  2 +-
 src/util/container_multihashmap.c   |  6 +++---
 src/util/container_multihashmap32.c |  4 ++--
 6 files changed, 15 insertions(+), 15 deletions(-)

diff --git a/src/fs/gnunet-service-fs_pr.c b/src/fs/gnunet-service-fs_pr.c
index b938e3593..f192c017d 100644
--- a/src/fs/gnunet-service-fs_pr.c
+++ b/src/fs/gnunet-service-fs_pr.c
@@ -691,7 +691,7 @@ GSF_iterate_pending_requests_ (GSF_PendingRequestIterator it, void *cls)
 {
   GNUNET_CONTAINER_multihashmap_iterate (
     pr_map,
-    (GNUNET_CONTAINER_MulitHashMapIteratorCallback) it,
+    (GNUNET_CONTAINER_MultiHashMapIteratorCallback) it,
     cls);
 }
 
diff --git a/src/include/gnunet_container_lib.h b/src/include/gnunet_container_lib.h
index 02bd32330..ce1b8f296 100644
--- a/src/include/gnunet_container_lib.h
+++ b/src/include/gnunet_container_lib.h
@@ -401,7 +401,7 @@ enum GNUNET_CONTAINER_MultiHashMapOption
  *         #GNUNET_NO if not.
  */
 typedef enum GNUNET_GenericReturnValue
-(*GNUNET_CONTAINER_MulitHashMapIteratorCallback)(
+(*GNUNET_CONTAINER_MultiHashMapIteratorCallback)(
   void *cls,
   const struct GNUNET_HashCode *key,
   void *value);
@@ -580,7 +580,7 @@ GNUNET_CONTAINER_multihashmap_size (
 int
 GNUNET_CONTAINER_multihashmap_iterate (
   struct GNUNET_CONTAINER_MultiHashMap *map,
-  GNUNET_CONTAINER_MulitHashMapIteratorCallback it,
+  GNUNET_CONTAINER_MultiHashMapIteratorCallback it,
   void *it_cls);
 
 
@@ -650,7 +650,7 @@ int
 GNUNET_CONTAINER_multihashmap_get_multiple (
   struct GNUNET_CONTAINER_MultiHashMap *map,
   const struct GNUNET_HashCode *key,
-  GNUNET_CONTAINER_MulitHashMapIteratorCallback it,
+  GNUNET_CONTAINER_MultiHashMapIteratorCallback it,
   void *it_cls);
 
 
@@ -668,7 +668,7 @@ GNUNET_CONTAINER_multihashmap_get_multiple (
 unsigned int
 GNUNET_CONTAINER_multihashmap_get_random (
   const struct GNUNET_CONTAINER_MultiHashMap *map,
-  GNUNET_CONTAINER_MulitHashMapIteratorCallback it,
+  GNUNET_CONTAINER_MultiHashMapIteratorCallback it,
   void *it_cls);
 
 
@@ -1550,7 +1550,7 @@ struct GNUNET_CONTAINER_MultiHashMap32Iterator;
  *         #GNUNET_NO if not.
  */
 typedef enum GNUNET_GenericReturnValue
-(*GNUNET_CONTAINER_MulitHashMapIterator32Callback)(
+(*GNUNET_CONTAINER_MultiHashMapIterator32Callback)(
   void *cls,
   uint32_t key,
   void *value);
@@ -1621,7 +1621,7 @@ GNUNET_CONTAINER_multihashmap32_get (
 int
 GNUNET_CONTAINER_multihashmap32_iterate (
   struct GNUNET_CONTAINER_MultiHashMap32 *map,
-  GNUNET_CONTAINER_MulitHashMapIterator32Callback it,
+  GNUNET_CONTAINER_MultiHashMapIterator32Callback it,
   void *it_cls);
 
 
@@ -1729,7 +1729,7 @@ int
 GNUNET_CONTAINER_multihashmap32_get_multiple (
   struct GNUNET_CONTAINER_MultiHashMap32 *map,
   uint32_t key,
-  GNUNET_CONTAINER_MulitHashMapIterator32Callback it,
+  GNUNET_CONTAINER_MultiHashMapIterator32Callback it,
   void *it_cls);
 
 
diff --git a/src/set/gnunet-set-ibf-profiler.c b/src/set/gnunet-set-ibf-profiler.c
index 944b63d30..6465b15b8 100644
--- a/src/set/gnunet-set-ibf-profiler.c
+++ b/src/set/gnunet-set-ibf-profiler.c
@@ -67,7 +67,7 @@ register_hashcode (struct GNUNET_HashCode *hash)
 
 static void
 iter_hashcodes (struct IBF_Key key,
-                GNUNET_CONTAINER_MulitHashMapIteratorCallback iter,
+                GNUNET_CONTAINER_MultiHashMapIteratorCallback iter,
                 void *cls)
 {
   struct GNUNET_HashCode replicated;
diff --git a/src/setu/gnunet-setu-ibf-profiler.c b/src/setu/gnunet-setu-ibf-profiler.c
index 944b63d30..6465b15b8 100644
--- a/src/setu/gnunet-setu-ibf-profiler.c
+++ b/src/setu/gnunet-setu-ibf-profiler.c
@@ -67,7 +67,7 @@ register_hashcode (struct GNUNET_HashCode *hash)
 
 static void
 iter_hashcodes (struct IBF_Key key,
-                GNUNET_CONTAINER_MulitHashMapIteratorCallback iter,
+                GNUNET_CONTAINER_MultiHashMapIteratorCallback iter,
                 void *cls)
 {
   struct GNUNET_HashCode replicated;
diff --git a/src/util/container_multihashmap.c b/src/util/container_multihashmap.c
index ab909484a..b61395471 100644
--- a/src/util/container_multihashmap.c
+++ b/src/util/container_multihashmap.c
@@ -308,7 +308,7 @@ GNUNET_CONTAINER_multihashmap_get (
 int
 GNUNET_CONTAINER_multihashmap_iterate (
   struct GNUNET_CONTAINER_MultiHashMap *map,
-  GNUNET_CONTAINER_MulitHashMapIteratorCallback it,
+  GNUNET_CONTAINER_MultiHashMapIteratorCallback it,
   void *it_cls)
 {
   int count;
@@ -781,7 +781,7 @@ int
 GNUNET_CONTAINER_multihashmap_get_multiple (
   struct GNUNET_CONTAINER_MultiHashMap *map,
   const struct GNUNET_HashCode *key,
-  GNUNET_CONTAINER_MulitHashMapIteratorCallback it,
+  GNUNET_CONTAINER_MultiHashMapIteratorCallback it,
   void *it_cls)
 {
   int count;
@@ -847,7 +847,7 @@ GNUNET_CONTAINER_multihashmap_get_multiple (
 unsigned int
 GNUNET_CONTAINER_multihashmap_get_random (
   const struct GNUNET_CONTAINER_MultiHashMap *map,
-  GNUNET_CONTAINER_MulitHashMapIteratorCallback it,
+  GNUNET_CONTAINER_MultiHashMapIteratorCallback it,
   void *it_cls)
 {
   unsigned int off;
diff --git a/src/util/container_multihashmap32.c b/src/util/container_multihashmap32.c
index 4ff4e1678..4ddf0053b 100644
--- a/src/util/container_multihashmap32.c
+++ b/src/util/container_multihashmap32.c
@@ -225,7 +225,7 @@ GNUNET_CONTAINER_multihashmap32_get (
 int
 GNUNET_CONTAINER_multihashmap32_iterate (
   struct GNUNET_CONTAINER_MultiHashMap32 *map,
-  GNUNET_CONTAINER_MulitHashMapIterator32Callback it,
+  GNUNET_CONTAINER_MultiHashMapIterator32Callback it,
   void *it_cls)
 {
   int count;
@@ -491,7 +491,7 @@ int
 GNUNET_CONTAINER_multihashmap32_get_multiple (
   struct GNUNET_CONTAINER_MultiHashMap32 *map,
   uint32_t key,
-  GNUNET_CONTAINER_MulitHashMapIterator32Callback it,
+  GNUNET_CONTAINER_MultiHashMapIterator32Callback it,
   void *it_cls)
 {
   int count;
-- 
2.38.1

Activities

schanzen

2023-02-06 05:27

administrator   ~0019757

4b227ccb101f66fbfec10b952589450403f95678

schanzen

2023-06-01 20:26

administrator   ~0020247

released some time ago

Issue History

Date Modified Username Field Change
2023-01-29 21:17 ulfvonbelow New Issue
2023-01-29 21:17 ulfvonbelow Tag Attached: patch
2023-01-29 21:17 ulfvonbelow File Added: 0001-INCLUDE-change-Mulit-Multi-in-G_C_MulitHashMapIterat.patch
2023-02-06 05:27 schanzen Assigned To => schanzen
2023-02-06 05:27 schanzen Status new => resolved
2023-02-06 05:27 schanzen Resolution open => fixed
2023-02-06 05:27 schanzen Fixed in Version => 0.19.4
2023-02-06 05:27 schanzen Note Added: 0019757
2023-02-06 05:46 schanzen Target Version => 0.19.4
2023-06-01 20:26 schanzen Note Added: 0020247
2023-06-01 20:26 schanzen Status resolved => closed