View Issue Details

IDProjectCategoryView StatusLast Update
0007581Talerwallet-corepublic2024-08-28 23:31
ReporterFlorian Dold Assigned ToFlorian Dold  
PriorityhighSeverityfeatureReproducibilityhave not tried
Status closedResolutionfixed 
Product Versiongit (master) 
Target Version0.13Fixed in Version0.13 
Summary0007581: implement soft KYC for balance limits [estimate 2d]
DescriptionThe wallet should request a KYC check when the balance exceeds a threshold
TagsNo tags attached.

Activities

Christian Grothoff

2024-01-06 22:26

manager   ~0020821

Bumping priority to 'high' as this is Milestone #7 on the KYC grant and thus should be finished by April at the latest.

Florian Dold

2024-06-26 17:37

manager   ~0022727

Needs the following:
1. querying and storing the limit announced by the exchange in /keys
2. in certain checkXXX operations, the wallet should return a flag to the UI to say that the KYC balance limit will be exceeded
3. when that is ignored, creating the operation must either:
 (a) raise an error
 (b) result in a transaction that is blocked for KYC

Florian Dold

2024-06-27 12:04

manager   ~0022742

=> We should have a transaction state for balance KYC

Florian Dold

2024-06-28 10:41

manager   ~0022754

Updating the estimate since it's rather complex and requires tx fsm changes.

Florian Dold

2024-07-08 16:44

manager   ~0022795

Last edited: 2024-07-08 16:49

Subtasks:
1. Store the exchange's balance thresholds in the wallet's database
2. Exchange entries must optionally have a KYC reserve associated with them. This reserve will be used for the merge operation of p2p payments *and* for KYC of withdrawals.
3. Threshold for withdrawals:
 - whenever a withdrawal exceeds the threshold, put the tx into a KYC state and create a KYC reserve (*not* the same reserve as the withdrawal reserve)
4. Threshold for p2p pull credit
5. Threshold for p2p push credit
6. Threshold for refunds

In wallet-core, we call the reserve that has KYC information associated with it the "merge reserve".
What's important: For withdrawals that exceed the withdrawal threshold, we don't do KYC on the reserve for the withdrawal, but on the P2P merge reserve for the involved exchange.

Florian Dold

2024-08-21 19:19

manager   ~0023022

Re-opening this, as the wallet-core transaction state should also reflect the balance-kyc status, the UIs should not have to query the exchange entry.

Florian Dold

2024-08-21 20:49

manager   ~0023024

The state machine now has been made simpler for the UIs, they just need to track the transaction's state, not the exchange entry state.

Issue History

Date Modified Username Field Change
2023-01-13 02:26 Florian Dold New Issue
2023-01-13 02:26 Florian Dold Status new => assigned
2023-01-13 02:26 Florian Dold Assigned To => Florian Dold
2023-01-13 17:03 Christian Grothoff Severity minor => feature
2023-01-13 17:03 Christian Grothoff Target Version 0.9.3 => 0.9.4
2023-04-13 20:36 Florian Dold Category wallet (TS core) => wallet-core
2023-04-21 14:50 Florian Dold Target Version 0.9.4 => post-1.0
2023-08-24 16:28 Florian Dold Assigned To Florian Dold =>
2023-08-24 16:28 Florian Dold Status assigned => acknowledged
2024-01-06 22:26 Christian Grothoff Priority normal => high
2024-01-06 22:26 Christian Grothoff Note Added: 0020821
2024-01-06 22:27 Christian Grothoff Status acknowledged => confirmed
2024-01-06 22:27 Christian Grothoff Product Version => git (master)
2024-03-08 00:43 Florian Dold Assigned To => Florian Dold
2024-03-08 00:43 Florian Dold Status confirmed => assigned
2024-03-08 00:43 Florian Dold Target Version post-1.0 => 0.11
2024-03-27 21:21 Florian Dold Summary implement soft KYC for balance limits => implement soft KYC for balance limits [estimate 5h]
2024-05-13 21:23 Christian Grothoff Target Version 0.11 => 0.13
2024-06-26 17:37 Florian Dold Note Added: 0022727
2024-06-27 12:04 Florian Dold Note Added: 0022742
2024-06-28 10:41 Florian Dold Summary implement soft KYC for balance limits [estimate 5h] => implement soft KYC for balance limits [estimate 8-12h]
2024-06-28 10:41 Florian Dold Note Added: 0022754
2024-07-08 16:20 Florian Dold Assigned To Florian Dold => avalos
2024-07-08 16:44 Florian Dold Note Added: 0022795
2024-07-08 16:46 Florian Dold Note Edited: 0022795
2024-07-08 16:47 Florian Dold Note Edited: 0022795
2024-07-08 16:49 Florian Dold Note Edited: 0022795
2024-07-31 18:29 Florian Dold Assigned To avalos => Florian Dold
2024-08-05 18:58 Florian Dold Summary implement soft KYC for balance limits [estimate 8-12h] => implement soft KYC for balance limits [estimate 2d]
2024-08-21 15:59 Florian Dold Status assigned => resolved
2024-08-21 15:59 Florian Dold Resolution open => fixed
2024-08-21 19:19 Florian Dold Status resolved => assigned
2024-08-21 19:19 Florian Dold Note Added: 0023022
2024-08-21 20:49 Florian Dold Status assigned => resolved
2024-08-21 20:49 Florian Dold Note Added: 0023024
2024-08-26 22:29 Christian Grothoff Fixed in Version => 0.13
2024-08-28 23:31 Christian Grothoff Status resolved => closed