View Issue Details

IDProjectCategoryView StatusLast Update
0007486TalerWeb site(s)public2022-11-21 01:03
Reporternervuri Assigned ToMS  
PrioritynormalSeverityminorReproducibilityalways
Status assignedResolutionopen 
Summary0007486: tsc no longer used, but build fails if it is not installed
DescriptionI cloned the www.git repo, followed the instructions in 'INSTALL', but got the following error when running 'configure':

Error: tool 'tsc' not available

The 'tsc' tool was used in the Makefile for compiling TypeScript (see commit bddc04c). Now I can't find it anywhere. It looks like tsc is no longer used and can be removed from 'build-system/configure.py'. I did, and the build works.

The attached patch also corrects a comment in the Makefile.
TagsNo tags attached.

Activities

nervuri

2022-11-19 17:25

reporter  

tsc.patch (653 bytes)   
diff --git a/Makefile b/Makefile
index 3b89192..42255a2 100644
--- a/Makefile
+++ b/Makefile
@@ -2,7 +2,7 @@
 
 include build-system/config.mk
 
-# All: build HTML pages in all languages and compile the
+# All: build HTML pages in all languages.
 .PHONY: all
 all:
 	./inc/update-messages
diff --git a/build-system/configure.py b/build-system/configure.py
index e1eadc8..e841dca 100644
--- a/build-system/configure.py
+++ b/build-system/configure.py
@@ -22,7 +22,6 @@ b.use(PosixTool("mkdir"))
 b.use(PosixTool("rm"))
 b.use(PosixTool("sh"))
 b.use(PosixTool("msgmerge"))
-b.use(PosixTool("tsc"))
 b.use(PosixTool("git"))
 b.use(BrowserTool())
 b.run()
tsc.patch (653 bytes)   

Stefan

2022-11-19 17:33

developer   ~0019455

Hi Nervuri,

just skip the command

./configure.

Stefan

Stefan

2022-11-19 17:37

developer   ~0019456

or use

./configure --variant=tmp

which should work (at least on my local machine)

Thank you for reporting.
Stefan

nervuri

2022-11-19 19:04

reporter   ~0019457

Even though I did manage to build the site, I tried your suggestions out of curiosity. If you start with a fresh clone of www.git and skip the ./configure command, 'make' then says:

  Makefile:3: build-system/config.mk: No such file or directory
  make: *** No rule to make target 'build-system/config.mk'. Stop.

And `./configure --variant=tmp` does not work unless you have 'tsc' installed.

So, like I said, tsc should be removed from 'build-system/configure.py' (see tsc.patch above).

---

Also, the INSTALL file contains this bit:

> Then invoke "bootstrap" and "configure". You must pass
> "--prefix=$P" and "--variant=$V" for some values of
> $P and $V to configure. The actual Web site
> will be installed at $P/$V.

However, that is not true, the website is installed in the `rendered` directory. So what are --prefix and --variant actually used for? Maybe that should be explained in the INSTALL file - which feels like it needs an overhaul, by the way, since it's rather confusing. I made some changes to it, to clarify it for myself. Check the patch below, tell me what you think. I removed `make submodules/init` and `make submodules/update`, since ./bootstrap already takes care of that (also, `make submodules/init` doesn't even work).
clarify-installation-instructions.patch (1,565 bytes)   
From f5593e89e6cbdabe3ee5fe0ecb7cc3b3d2bc7ee3 Mon Sep 17 00:00:00 2001
From: nervuri <seva@nervuri.net>
Date: Sat, 19 Nov 2022 17:48:00 +0000
Subject: [PATCH Taler website] clarify installation instructions

---
 INSTALL | 34 ++++++++++++++++++++--------------
 1 file changed, 20 insertions(+), 14 deletions(-)

diff --git a/INSTALL b/INSTALL
index 45dadf7..b53c10e 100644
--- a/INSTALL
+++ b/INSTALL
@@ -1,21 +1,16 @@
 Installation instructions
 -------------------------
 
-For Debian:
-===========
+Debian prerequisites
+====================
 
 Simply install:
 
-# apt-install python3-ruamel.yaml python3-jinja2 python3-babel git
-
-Then invoke "bootstrap" and "configure". You must pass
-"--prefix=$P" and "--variant=$V" for some values of
-$P and $V to configure.  The actual Web site
-will be installed at $P/$V.
+# apt install python3-ruamel.yaml python3-jinja2 python3-babel git
 
 
-For NetBSD:
-===========
+NetBSD prerequisites
+====================
 
 Install python3.7, py37-babel, npm, nodejs from pkgsrc.
 
@@ -24,10 +19,21 @@ Adjust the values in config.mk:
        PYTHON=python3.7
        BABEL=pybabel-3.7
 
-make submodules/init
-make submodules/update
+
+Build website
+=============
+
+Invoke "bootstrap" and "configure".  You must pass
+"--prefix=$P" and "--variant=$V" for some values of
+$P and $V to configure.  Then run "make".  The actual
+Web site will be installed at $P/$V.
+
+./bootstrap
+./configure --prefix=$P --variant=$V
 make
 
-Use
+
+Run website
+===========
+
 env BROWSER=firefox make run
-to run the website
-- 
2.35.1

nervuri

2022-11-19 19:15

reporter   ~0019458

While we're at it, here's one more small fix, which gets `make run` to start the python http server in the "rendered/" dir. This gets the browser to display the favicon. Also, it just makes more sense.

If I ought to make separate issues for these other patches, let me know.
start-python-http-server-in-rendered-dir.patch (695 bytes)   
From 3827b6de552e2d77c915484078f41653b01774b2 Mon Sep 17 00:00:00 2001
From: nervuri <seva@nervuri.net>
Date: Sat, 19 Nov 2022 16:32:58 +0000
Subject: [PATCH Taler website] start python http server in "rendered/" dir

Makes more sense. Also, the browser now shows the favicon.
---
 Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Makefile b/Makefile
index 42255a2..b3c9dc9 100644
--- a/Makefile
+++ b/Makefile
@@ -10,8 +10,8 @@ all:
 
 .PHONY: run
 run: all
-	$(browser) http://0.0.0.0:8000/rendered/en &
-	$(python) -m http.server
+	$(browser) http://0.0.0.0:8000/en/ &
+	$(python) -m http.server --directory rendered/
 
 variant = $(opt_variant)
 
-- 
2.35.1

Stefan

2022-11-19 19:32

developer   ~0019459

Your suggestions are good points indeed.
Let me assign this bugfix issue to Marcello as he might be more familiar with the build process.
I will update all other 'Install' guidelines for the other web sites in the aftermath.
Stefan

Issue History

Date Modified Username Field Change
2022-11-19 17:25 nervuri New Issue
2022-11-19 17:25 nervuri Status new => assigned
2022-11-19 17:25 nervuri Assigned To => Stefan
2022-11-19 17:25 nervuri File Added: tsc.patch
2022-11-19 17:33 Stefan Note Added: 0019455
2022-11-19 17:37 Stefan Note Added: 0019456
2022-11-19 19:04 nervuri Note Added: 0019457
2022-11-19 19:04 nervuri File Added: clarify-installation-instructions.patch
2022-11-19 19:15 nervuri Note Added: 0019458
2022-11-19 19:15 nervuri File Added: start-python-http-server-in-rendered-dir.patch
2022-11-19 19:32 Stefan Note Added: 0019459
2022-11-19 19:32 Stefan Assigned To Stefan => MS