View Issue Details

IDProjectCategoryView StatusLast Update
0007446Talerwallet-corepublic2023-09-23 15:09
Reportersebasjm Assigned Tosebasjm  
PrioritynormalSeverityfeatureReproducibilityhave not tried
Status closedResolutionfixed 
Product Version0.9.1 
Target Version0.9.3Fixed in Version0.9.3 
Summary0007446: dev mode is not persisted after restart
DescriptionService worker is a short lived process, so any setting on the wallet core should persist restart.
TagsNo tags attached.



2022-11-16 18:55

developer   ~0019428

should we add this into the wallet-core db?

Christian Grothoff

2022-11-18 22:40

manager   ~0019452

Does it even make sense to persist dev-mode? I actually think turning it off on restart might be a good thing. Devs can re-enable, but having it on by accident might be bad...


2022-11-23 00:07

developer   ~0019473

On iOS, Dev-Mode is persisted in the application settings, which is just two words of code preceding a variable definition:
    @AppStorage("developerMode") var developerMode: Bool = false
Next time the app launches it will not init with false, but use the value for key "developerMode". If I delete the first two words, the app will fall back to false at launch - after reboot, or if the user manually kicked it off the background app list, or the user launched so many other apps while we are in the background that iOS runs out of memory and kills us - which could take days if the user doesn't launch many other apps. In this case they would maybe see Dev-Mode active for multiple days, and on other days falling back to inactive even within minutes (if they launch many other apps before coming back to us). Such unpredictability is not the best user experience - but OK, it's just developer mode...


2022-11-23 12:57

developer   ~0019477

> I actually think turning it off on restart might be a good thing.

Restart the browser yes, but service worker may restart (wiping out wallet memory) after short time.

I will implement saving the state in localStorage (the web version of marc's description) and sync wallet on startup.


2023-04-26 16:28

developer   ~0020163

fixed with the implementation of feature flags

Issue History

Date Modified Username Field Change
2022-11-07 16:30 sebasjm New Issue
2022-11-07 16:30 sebasjm Status new => assigned
2022-11-07 16:30 sebasjm Assigned To => Florian Dold
2022-11-16 18:55 sebasjm Note Added: 0019428
2022-11-18 22:40 Christian Grothoff Note Added: 0019452
2022-11-23 00:07 MarcS Note Added: 0019473
2022-11-23 12:57 sebasjm Note Added: 0019477
2022-11-23 12:57 sebasjm Assigned To Florian Dold => sebasjm
2023-01-13 17:08 Christian Grothoff Severity minor => feature
2023-01-13 17:08 Christian Grothoff Target Version git (master) => 0.9.4
2023-04-13 20:36 Florian Dold Category wallet (TS core) => wallet-core
2023-04-26 16:28 sebasjm Status assigned => resolved
2023-04-26 16:28 sebasjm Resolution open => fixed
2023-04-26 16:28 sebasjm Note Added: 0020163
2023-04-29 13:49 Christian Grothoff Fixed in Version => 0.9.3
2023-04-29 13:49 Christian Grothoff Target Version 0.9.4 => 0.9.3
2023-09-23 15:09 Christian Grothoff Status resolved => closed