View Issue Details

IDProjectCategoryView StatusLast Update
0007440Talerwallet (WebExtensions)public2022-11-18 22:42
ReporterChristian Grothoff Assigned Tosebasjm  
PrioritynormalSeverityfeatureReproducibilityN/A
Status resolvedResolutionfixed 
Platformi7OSDebian GNU/LinuxOS Versionsqueeze
Product Version0.9 
Target Version0.9.1Fixed in Version0.9.1 
Summary0007440: cannot specify expiration for push payments in WebExtension
DescriptionWhen sending money to another wallet, it must be possible for the user to specify an expiration time for the push payment, as only then the coins that were pushed can be recovered if the receiver didn't accept the payment.

Similarly, we should also allow setting an expiration date when invoicing (technically a separate issue, but very symmetric so should be done at the same time).

This is also missing in the other wallets.
TagsNo tags attached.

Relationships

related to 0007439 assignedgrote cannot specify expiration for push payments in Android wallet 

Activities

sebasjm

2022-11-08 03:30

developer   ~0019391

first, it should be implemented by wallet-core :)

* parse the PeerContractTerms
* use amount from CT (instead of the request)
* use expiration from the CT (instead of hardcoded)
* both push and pull request

cc @grote @marc

grote

2022-11-08 15:00

developer   ~0019392

can you please get me an API diff together with the wallet-core version this first lands in, once done, please?
additional info on how the current API flow must be adapted will be appreciated.

sebasjm

2022-11-08 16:34

developer   ~0019397

@grote yes, AFAIK this is covered by the documentation generation that @florian mentioned

FTR this will also apply to pull payments

sebasjm

2022-11-10 14:13

developer   ~0019398

at 5c742afb

Issue History

Date Modified Username Field Change
2022-11-06 22:55 Christian Grothoff New Issue
2022-11-06 22:55 Christian Grothoff Status new => assigned
2022-11-06 22:55 Christian Grothoff Assigned To => sebasjm
2022-11-06 22:56 Christian Grothoff Relationship added related to 0007439
2022-11-08 03:30 sebasjm Note Added: 0019391
2022-11-08 15:00 grote Note Added: 0019392
2022-11-08 16:34 sebasjm Note Added: 0019397
2022-11-10 14:13 sebasjm Status assigned => resolved
2022-11-10 14:13 sebasjm Resolution open => fixed
2022-11-10 14:13 sebasjm Note Added: 0019398
2022-11-18 22:42 Christian Grothoff Fixed in Version => 0.9.1