View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0007050 | Anastasis | C reducer implementation | public | 2021-10-20 19:03 | 2023-06-15 17:55 |
| Reporter | Florian Dold | Assigned To | Christian Grothoff | ||
| Priority | normal | Severity | minor | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | ||
| Product Version | Git master | ||||
| Target Version | 0.3.0 | Fixed in Version | 0.3.0 | ||
| Summary | 0007050: recovery state has obscure and/or wrong field names | ||||
| Description | state.recovery_document => eh, this isn't actually the downloaded recovery document, but some internal state the reducer stores. state.recovery_document.core_secret => this doesn't seem to be the core secret, but the encrypted core secret state.recovery_document.cs => huh? state.recovery_document.cs[*].salt => should be truth_salt? state.recovery_document.cs[*].key_share => wouldn't this be the encrypted key share? actually it might be the plain one, but in the recovery doc we call "key_share_data" the *encrypted* key share ... state.recovery_document.dps => huh?! state.recovery_document.dps[*].salt => what salt is this? state.recovery_document.dps[*].emk => huh?!?! | ||||
| Tags | No tags attached. | ||||
|
|
(I now mostly know what all these are, but we should still both fix the bad names and document it in form of TypeScript declarations.) |
|
|
AFAICT, all these fields could be replaced by the recovery_data field used by the TS reducer: https://git.taler.net/wallet-core.git/tree/packages/anastasis-core/src/reducer-types.ts#n91 |
|
|
Field names are now less obscure. |
|
|
Fix committed to master branch. |
|
|
Fix committed to master branch. |
|
anastasis-gtk: master c1885fe5 2022-04-13 21:10 Details Diff |
-fix 0007050 |
Affected Issues 0007050 |
|
| mod - src/anastasis/anastasis-gtk_action.c | Diff File | ||
|
anastasis: master 1398cca5 2022-04-13 21:10 Details Diff |
-fix 0007050 |
Affected Issues 0007050 |
|
| mod - src/lib/anastasis_recovery.c | Diff File | ||
| mod - src/reducer/anastasis_api_recovery_redux.c | Diff File | ||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2021-10-20 19:03 | Florian Dold | New Issue | |
| 2021-10-20 19:03 | Florian Dold | Status | new => assigned |
| 2021-10-20 19:03 | Florian Dold | Assigned To | => Christian Grothoff |
| 2021-10-20 19:04 | Florian Dold | Note Added: 0018446 | |
| 2021-10-20 19:05 | Florian Dold | Description Updated | |
| 2021-10-20 19:07 | Florian Dold | Description Updated | |
| 2022-04-12 22:19 | Florian Dold | Note Added: 0018860 | |
| 2022-04-13 19:11 | Christian Grothoff | Status | assigned => resolved |
| 2022-04-13 19:11 | Christian Grothoff | Resolution | open => fixed |
| 2022-04-13 19:11 | Christian Grothoff | Fixed in Version | => 0.3.0 |
| 2022-04-13 19:11 | Christian Grothoff | Note Added: 0018870 | |
| 2022-04-13 19:11 | Christian Grothoff | Product Version | => Git master |
| 2022-04-13 19:11 | Christian Grothoff | Target Version | => 0.3.0 |
| 2022-09-26 20:50 | Christian Grothoff | Status | resolved => closed |
| 2023-06-15 17:54 | Christian Grothoff | Changeset attached | => anastasis master 1398cca5 |
| 2023-06-15 17:54 | Christian Grothoff | Note Added: 0020274 | |
| 2023-06-15 17:55 | Christian Grothoff | Changeset attached | => anastasis-gtk master c1885fe5 |
| 2023-06-15 17:55 | Christian Grothoff | Note Added: 0020288 |
