View Issue Details

IDProjectCategoryView StatusLast Update
0006952Talerdocumentationpublic2023-09-23 15:09
ReporterFlorian Dold Assigned ToFlorian Dold  
PrioritynormalSeveritytextReproducibilityhave not tried
Status closedResolutionfixed 
Product Versiongit (master) 
Target Version0.9.3Fixed in Version0.9.3 
Summary0006952: document how public /pay handles refunded coins
DescriptionThe current implementation allows them, but excludes the refunded amount from the total payment amount.
TagsNo tags attached.


related to 0007267 closedoec TEH_make_coin_known needs proper conflict handling and evidence gathering 


Florian Dold

2021-07-23 14:18

manager   ~0018008

From our workshop discussion: The merchant should actually just *reject* /pay requests with refunded coins, as due to the exchange API, such payments can never work in the first place. Once a coin is refunded, it can't be spent on the same h_contract_terms again.

The merchant code should not accommodate with extra, complex logic for an input that will lead to an error at the exchange anyway.

Florian Dold

2023-04-05 18:21

manager   ~0020028

Actually it turns out that the exchange doesn't properly document how /deposit handles refunded coins for the same h_contract_terms.

While trying to experiment with the exchange's behavior, I stumbled on 0007792.

Florian Dold

2023-04-05 18:22

manager   ~0020029

Assigning to Christian to review the exchange docs for coin deposit/refund, which in turn informs the documentation for the merchant's /pay endpoint.

Christian Grothoff

2023-04-08 09:59

manager   ~0020040

56e7647..991e5d2 clarifies the /deposit (and /batch-deposit) endpoints with respect to coin re-use.
991e5d2..a7dd26c clairfies the /pay endpoint hopefully making it clearer that you must not use the same coin-pub a second time for a purchase of the same contract after a /refund for the same purchase.

Florian Dold

2023-06-02 14:40

manager   ~0020250

Documentation LGTM now.

Issue History

Date Modified Username Field Change
2021-07-23 13:42 Florian Dold New Issue
2021-07-23 13:42 Florian Dold Status new => assigned
2021-07-23 13:42 Florian Dold Assigned To => Christian Grothoff
2021-07-23 14:18 Florian Dold Note Added: 0018008
2021-07-23 14:22 Christian Grothoff Assigned To Christian Grothoff => Florian Dold
2021-07-23 18:37 Christian Grothoff Severity minor => text
2021-08-01 15:07 Christian Grothoff Category mechant backend => documentation
2021-08-01 15:07 Christian Grothoff Product Version => git (master)
2023-04-04 16:08 Florian Dold Target Version => 0.9.3
2023-04-05 18:21 Florian Dold Note Added: 0020028
2023-04-05 18:21 Florian Dold Assigned To Florian Dold => Christian Grothoff
2023-04-05 18:22 Florian Dold Note Added: 0020029
2023-04-08 09:56 Christian Grothoff Relationship added related to 0007267
2023-04-08 09:59 Christian Grothoff Note Added: 0020040
2023-04-08 10:00 Christian Grothoff Assigned To Christian Grothoff => Florian Dold
2023-04-08 10:00 Christian Grothoff Status assigned => feedback
2023-06-02 14:40 Florian Dold Status feedback => resolved
2023-06-02 14:40 Florian Dold Resolution open => fixed
2023-06-02 14:40 Florian Dold Note Added: 0020250
2023-09-23 15:07 Christian Grothoff Fixed in Version => 0.9.3
2023-09-23 15:09 Christian Grothoff Status resolved => closed