View Issue Details

IDProjectCategoryView StatusLast Update
0006872GNUnetbuild processpublic2021-06-10 22:53
ReporterBrendan Assigned Toschanzen  
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Product VersionGit master 
Target Version0.15.0Fixed in Version0.15.0 
Summary0006872: test_gnunet_peerinfo.py fails when LANG isn't set
Descriptionbecause it runs
    mylang = os.environ['LANG']

LANG isn't set in Guix CI and I think it's expected programs should handle environment variables not being set.
Additional Information
FAIL: test_gnunet_peerinfo.py
=============================

Traceback (most recent call last):
  File "./test_gnunet_peerinfo.py", line 36, in <module>
    mylang = os.environ['LANG']
  File "/gnu/store/9w9jvy3bgjg4qaqmrij01nbppiccqr7c-python-3.8.2/lib/python3.8/os.py", line 675, in __getitem__
    raise KeyError(key) from None
KeyError: 'LANG'
FAIL test_gnunet_peerinfo.py (exit status: 1)

TagsNo tags attached.

Activities

schanzen

2021-05-17 15:06

manager   ~0017865

Fixed in c2cd7ec03..3b3faa6bc

Brendan

2021-05-18 03:03

reporter   ~0017871

Later it tries to set it back to the null value:


Traceback (most recent call last):
  File "./test_gnunet_peerinfo.py", line 142, in <module>
    os.environ['LANG'] = mylang
  File "/gnu/store/9w9jvy3bgjg4qaqmrij01nbppiccqr7c-python-3.8.2/lib/python3.8/os.py", line 680, in __setitem__
    value = self.encodevalue(value)
  File "/gnu/store/9w9jvy3bgjg4qaqmrij01nbppiccqr7c-python-3.8.2/lib/python3.8/os.py", line 750, in encode
    raise TypeError("str expected, not %s" % type(value).__name__)
TypeError: str expected, not NoneType
FAIL test_gnunet_peerinfo.py (exit status: 1)

schanzen

2021-05-18 09:52

manager   ~0017872

Try 3b3faa6bc..00c21152e

Brendan

2021-05-19 09:12

reporter   ~0017879

It works.

Issue History

Date Modified Username Field Change
2021-05-17 12:59 Brendan New Issue
2021-05-17 15:06 schanzen Assigned To => schanzen
2021-05-17 15:06 schanzen Status new => resolved
2021-05-17 15:06 schanzen Resolution open => fixed
2021-05-17 15:06 schanzen Fixed in Version => Git master
2021-05-17 15:06 schanzen Note Added: 0017865
2021-05-17 15:06 schanzen Target Version => 0.14.2
2021-05-17 15:07 schanzen Fixed in Version Git master => 0.14.2
2021-05-18 03:03 Brendan Status resolved => feedback
2021-05-18 03:03 Brendan Resolution fixed => reopened
2021-05-18 03:03 Brendan Note Added: 0017871
2021-05-18 09:52 schanzen Note Added: 0017872
2021-05-19 09:12 Brendan Note Added: 0017879
2021-05-19 09:12 Brendan Status feedback => assigned
2021-05-19 10:03 schanzen Status assigned => resolved
2021-05-19 10:03 schanzen Resolution reopened => fixed
2021-06-10 19:37 schanzen Target Version 0.14.2 => 0.15.0
2021-06-10 22:53 schanzen Fixed in Version 0.14.2 => 0.15.0