View Issue Details

IDProjectCategoryView StatusLast Update
0006859Talermechant backendpublic2021-05-12 16:17
Reportersebasjm Assigned Tosebasjm  
PrioritynormalSeverityfeatureReproducibilityhave not tried
Status feedbackResolutionopen 
Product Versiongit (master) 
Target Versiongit (master) 
Summary0006859: add fullfil url into the default configuration of the instance
Descriptioncurrently there is no fulfillment url when creating an instance

a merchant can have it instance configured with a default url that redirect to the merchant instance website after paying (or a thankyou page)

order may still override the value when creating the order.

also, url should be absolute and always start with https since it will be automatically redirected from the wallet.
TagsNo tags attached.

Activities

Christian Grothoff

2021-05-11 12:25

manager   ~0017818

I do not think this is what we want: (1) the fulfillment URLs tend to be highly personalized to the order, so a default makes little sense, and (2) they do not have to start with http/https, IIRC taler:// was also possible to show a message inside of the wallet.

Florian Dold

2021-05-11 12:30

manager   ~0017819

This seems to not be documented (?), but we changed this a while ago:

1. Fulfillment URLs should always be http(s)
2. *Instead* of a fulfillment URL, a fulfillment_message can also be shown.

We made this change because (2) allows i18n via the fulfillment_message_i18n property, whereas i18n would be difficult with a taler://fulfillment-success URL.

Christian Grothoff

2021-05-11 12:33

manager   ~0017821

Ah, I see. Well, it should be documented then. Still, I think having a per-instance default is not warranted, wdyt?

Florian Dold

2021-05-11 12:42

manager   ~0017822

I've added documentation for the field to the contract terms specification in the merchant API reference.

I don't see the need for a per-instance default, especially since this is very easy to specify for storefronts (no crypto / parsing / etc. necessary). But the UI should allow specifying either the message or URL.

Christian Grothoff

2021-05-11 12:57

manager   ~0017824

Just to clarify: by UI, you mean the _order creation_ UI in the SPA, right?

sebasjm

2021-05-11 18:23

developer   ~0017829

Roger that, the UI does allow setting the fulfillment url (and will allow add the messsage) but its optional. Are we ok to make this required?
 
I see rather unnecessary if the message is always "thanks for buying" and a default url may look something like https://acme.com/success/{ORDER_ID}.

Christian Grothoff

2021-05-11 22:55

manager   ~0017837

I think the fulfillment URL _must_ be optional because it has implications for repurchase detection. Right, Florian?

Florian Dold

2021-05-12 14:56

manager   ~0017842

Yes. It must be optional, or alternatively contain some random ID. Otherwise, the repurchase detection logic might prevent users from completing a purchase.

sebasjm

2021-05-12 15:50

developer   ~0017843

ACK
So, if there is not message nor url the wallet today is showing a message "Redirecting..." but no redirecting because there is no contractTerms.fulfillment_url in the response.

Should we add a default message for this case?

Florian Dold

2021-05-12 16:17

manager   ~0017844

Yes. Instead of "redirecting ...", we should show the fulfillment_message, or a default message if no fulfillment_message is specified.

(Generally either fulfillment_url or fulfillment_message should be specified though.)

Issue History

Date Modified Username Field Change
2021-05-10 16:47 sebasjm New Issue
2021-05-10 16:47 sebasjm Status new => assigned
2021-05-10 16:47 sebasjm Assigned To => Christian Grothoff
2021-05-11 12:25 Christian Grothoff Note Added: 0017818
2021-05-11 12:30 Florian Dold Note Added: 0017819
2021-05-11 12:33 Christian Grothoff Note Added: 0017821
2021-05-11 12:42 Florian Dold Note Added: 0017822
2021-05-11 12:57 Christian Grothoff Note Added: 0017824
2021-05-11 18:23 sebasjm Note Added: 0017829
2021-05-11 22:55 Christian Grothoff Note Added: 0017837
2021-05-11 22:55 Christian Grothoff Assigned To Christian Grothoff => Florian Dold
2021-05-11 22:56 Christian Grothoff Status assigned => feedback
2021-05-12 14:56 Florian Dold Note Added: 0017842
2021-05-12 14:56 Florian Dold Assigned To Florian Dold => sebasjm
2021-05-12 15:50 sebasjm Note Added: 0017843
2021-05-12 16:17 Florian Dold Note Added: 0017844