View Issue Details

IDProjectCategoryView StatusLast Update
0006786Talerexchange API (C)public2021-09-02 18:14
Reportersebasjm Assigned ToChristian Grothoff  
PrioritynormalSeveritycrashReproducibilityalways
Status closedResolutionfixed 
Product Versiongit (master) 
Target Version0.8Fixed in Version0.8 
Summary0006786: creating a reserve with a invalid exchange URL make the merchant crash
DescriptionSending a create request to /private/reserves with exchange_url with the missing slash at the end.
Steps To Reproducecurl 'http://localhost:9966/private/reserves' \
  -H 'Authorization: Bearer secret-token:super_secret_do_not_show' \
  --data-raw '{"wire_method":"x-taler-bank","initial_balance":"COL:18","exchange_url":"http://exchange.taler:8081"}'

Additional InformationIt crash when trying to request the exchange for the keys function request_keys at exchange_api_handle.c:1903
TagsNo tags attached.

Activities

Christian Grothoff

2021-03-05 21:49

manager   ~0017603

2cb5982..8e540b3 fixes the issue, together with the companion fix in exchange and gana.

Christian Grothoff

2021-09-02 18:14

manager   ~0018232

Fix committed to master branch.

Related Changesets

exchange: master ca5f0c4d

2021-03-05 21:41:55

Christian Grothoff

Details Diff
fix 0006786: do not die on bogus URL Affected Issues
0006786
mod - contrib/gana Diff File
mod - src/lib/auditor_api_deposit_confirmation.c Diff File
mod - src/lib/auditor_api_exchanges.c Diff File
mod - src/lib/auditor_api_handle.c Diff File
mod - src/lib/exchange_api_deposit.c Diff File
mod - src/lib/exchange_api_deposits_get.c Diff File
mod - src/lib/exchange_api_handle.c Diff File
mod - src/lib/exchange_api_link.c Diff File
mod - src/lib/exchange_api_melt.c Diff File
mod - src/lib/exchange_api_recoup.c Diff File
mod - src/lib/exchange_api_refreshes_reveal.c Diff File
mod - src/lib/exchange_api_refund.c Diff File
mod - src/lib/exchange_api_reserves_get.c Diff File
mod - src/lib/exchange_api_transfers_get.c Diff File
mod - src/lib/exchange_api_wire.c Diff File
mod - src/lib/exchange_api_withdraw2.c Diff File

Issue History

Date Modified Username Field Change
2021-03-04 16:15 sebasjm New Issue
2021-03-04 16:15 sebasjm Status new => assigned
2021-03-04 16:15 sebasjm Assigned To => Christian Grothoff
2021-03-05 21:49 Christian Grothoff Note Added: 0017603
2021-03-05 21:50 Christian Grothoff Status assigned => resolved
2021-03-05 21:50 Christian Grothoff Resolution open => fixed
2021-03-05 21:50 Christian Grothoff Fixed in Version => 0.9
2021-03-05 21:50 Christian Grothoff Target Version git (master) => 0.9
2021-07-30 13:57 Christian Grothoff Fixed in Version 0.9 => 0.8.1
2021-07-30 13:59 Christian Grothoff Target Version 0.9 => 0.8.1
2021-07-30 14:02 Christian Grothoff Fixed in Version 0.8.1 => 0.8
2021-07-30 14:02 Christian Grothoff Target Version 0.8.1 => 0.8
2021-08-24 16:23 Christian Grothoff Status resolved => closed
2021-09-02 18:13 Christian Grothoff Changeset attached => Taler-exchange master ca5f0c4d
2021-09-02 18:14 Christian Grothoff Note Added: 0018232