View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0011662 | Taler | exchange | public | 2026-07-21 14:08 | 2026-07-28 16:15 |
| Reporter | adridg | Assigned To | Florian Dold | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Product Version | 1.5 | ||||
| Target Version | 1.6 | ||||
| Summary | 0011662: Fails to compile with Clang, non-standard C | ||||
| Description | There's two places where a floating-point constant is written with a non-standard `d` suffix. Standard C recognizes `f` suffixes (for float constants), **no** suffix (for double), and `l` (for long double). This fails to compile with Clang on FreeBSD. I also can't find `d` as a documented suffix for floating-point constants in the GCC manual. Trivial patch attached. | ||||
| Tags | No tags attached. | ||||
| Attached Files | patch-src_benchmark_taler-exchange-benchmark.c (873 bytes)
--- src/benchmark/taler-exchange-benchmark.c.orig 2026-07-21 11:10:12 UTC
+++ src/benchmark/taler-exchange-benchmark.c
@@ -296,7 +296,7 @@ run (void *cls,
GNUNET_TIME_UNIT_ZERO,
amount_1,
MHD_HTTP_OK));
- if (eval_probability (refresh_rate / 100.0d))
+ if (eval_probability (refresh_rate / 100.0))
{
char *melt_label;
char *reveal_label;
@@ -628,7 +628,7 @@ main (int argc,
" * Reserve=%u * Parallel=%u, operations in %s\n",
howmany_coins,
howmany_coins,
- howmany_coins * (refresh_rate / 100.0d),
+ howmany_coins * (refresh_rate / 100.0),
howmany_reserves,
howmany_clients,
GNUNET_STRINGS_relative_time_to_string (
| ||||
|
|
commit 4fe3e8b23bfccd0d0d1efdd8513059470bc4977d (HEAD -> master) Author: Florian Dold <dold@taler.net> Date: Tue Jul 28 16:13:16 2026 +0200 benchmark: drop non-standard 'd' suffix on floating constants C has no 'd' floating-point suffix; gcc accepts it silently but clang rejects it, breaking the build on FreeBSD. Issue: https://bugs.taler.net/n/11662 |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2026-07-21 14:08 | adridg | New Issue | |
| 2026-07-21 14:08 | adridg | File Added: patch-src_benchmark_taler-exchange-benchmark.c | |
| 2026-07-28 16:15 | Florian Dold | Assigned To | => Florian Dold |
| 2026-07-28 16:15 | Florian Dold | Status | new => resolved |
| 2026-07-28 16:15 | Florian Dold | Resolution | open => fixed |
| 2026-07-28 16:15 | Florian Dold | Note Added: 0029250 | |
| 2026-07-28 16:15 | Florian Dold | Target Version | => 1.6 |
