| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0011213 | Taler | merchant backend | public | 2026-03-09 13:28 | 2026-06-10 18:09 |
| Reporter | vecirex | Assigned To | Christian Grothoff | ||
| Priority | normal | Severity | tweak | Reproducibility | always |
| Status | resolved | Resolution | reopened | ||
| Product Version | git (master) | ||||
| Target Version | 1.6 | Fixed in Version | 1.6 | ||
| Summary | 0011213: In email auth code user "admin" is (always?) shown as login name | ||||
| Description | I see this the first time (introduced in taler-merchant v1.5.0?): 1. Not sure if the login line in the email should even be showed, but in any case it's not admin; I used "mechant1_5_0" as username. 2. Confusion login vs. username should also be avoided; if this line should stay, then I'd suggest to say username. | ||||
| Tags | No tags attached. | ||||
|
|
This can be reproduced also when doing a login. taler-merchant-auth-code-email-shows-admin-login-2.png (19,750 bytes) |
|
|
cb9b9098..c183066b removes the bogus "Login: admin" line from the message. We don't actually HAVE the instance right now in this place, so giving the right login will take longer => 1.8. |
|
|
Remove as blocking 0011212 (just let it related), workaround looks good (cf. screenshot). Ty! taler-merchant-auth-code-email-shows-admin-login-nomore.png (22,070 bytes) |
|
|
Should be fixed with 125dbecf..1570cb05 |
|
|
Hernani: you might want to put this on your personal QC list when testing v1.6: the "Login" should now be back in the message, just this time with the correct instance name. |
|
|
Reopened this ticket, shipping feedback. I reported in another ticket -- 0011470 -- that we have a regression... will close that ticket, however, as we can solve the issue here. |
|
|
Yes, I can confirm this not (!) to work as of taler-merchant v1.6.2 w/ taler-merchant-webui v1.6.4: tested live on betel. Bildschirmfoto 2026-06-10 um 03.13.08.png (79,273 bytes) |
|
|
This clearly first needs a taler-harness test, if we get regressions like this :-(. @Florian: can you do that, please? |
|
|
commit c2b8c6170d2262fe325e1c2b6b5a95ca63d2b149 (HEAD -> master, origin/master, origin/HEAD) Author: Florian Dold <florian@dold.me> Date: Wed Jun 10 12:24:26 2026 +0200 harness: check for instance name in self-provisioning MFA message |
|
|
$ taler-harness run-integrationtests merchant-self-provision-activation [...] FAIL Expected values to be strictly deep-equal: + actual - expected + 'admin' - 'my-awesome-instance' -- end -- |
|
|
Fixed in d8687409..9cf48c76: needed to pass instance_name explicitly into MFA logic (as request does to to 'admin' instance) and change the schema as the yet-to-be-created instance obviously doesn't yet exist and so we have a name but no ID. |
