| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0010938 | Taler | merchant backoffice SPA | public | 2026-01-28 19:16 | 2026-01-30 06:48 |
| Reporter | vecirex | Assigned To | sebasjm | ||
| Priority | high | Severity | text | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Product Version | git (master) | ||||
| Target Version | 1.4 | Fixed in Version | 1.4 | ||
| Summary | 0010938: MFA window shows strings in wrong lang (at least: DE and FR), white space issue and mixes starting with ending for phone number | ||||
| Description | Various issues, seen in production (should also be true in newest versions); seen while testing password reset issues: 1. Still EN text with DE settings 2. For the EN text, there's a white space missing; see left of "to send a new code" 3. The given phone number doesn't start, but actually ends with "2532" As for the 3., I first realized this with the FR lang setting at a Biel/Bienne customer when assisting an instance setup and thought this would be an FR-specific issue: apparently, however, it still persists in at least also DE, the customer herself immediately spotted the mistake, as she was carefully reading everything... | ||||
| Tags | No tags attached. | ||||
|
|
Title was weird; fixed. |
|
|
fix typos in descr text |
|
|
1. Wait a moment. This bug is reported for v1.2.6 and not the latest v1.3.0 --> The string issue should be solved already in v.1.3! 2. Let me investigate where this is a bug in the code. Trivial to solve. 3. LOL: "mixes starting with ending for phone number" --> Indeed, this is a bug and it was already mentioned by Vlada in the last QC meeting. |
|
|
In more extensive testing back in Nov/Dec, I can also remember cases where certain strings were hard coded and thus not reflected in weblate: it should be checked if this does apply here, also if there are different kinds of MFA windows using other parts of the code or if there's only one for this, given login, registering, changing PWs etc.: to avoid rabbit holes, I don't look deeper into this. :) |
|
|
I will care for the above mentioned bugs and then assign this ticket to Sebastian for further/deeper looking into this issue with hard-coded strings. THX for reporting! |
|
|
OK, @stefan: Can you check which of the issues are solved in v1.3.0? TOPS/CHF test instance runs v1.3.0. I also just saw w/ fdold that the demo and test instances of taler.net are even running v1.3.3 already, which I didn't yet try. I assume to solve all three issues for sure (at least in DE and EN), we will need a merchant v1.3.4? |
|
|
I tested this for v1.3.0 on an instance running on hacktivism and I can reproduce the bugs 1 to 3 (see the attached screenshot), although they have already been fixed in Weblate and in the source code /taler-typescript-core/packages/merchant-backoffice-ui/src/components/SolveMFA.tsx ( https://git-www.taler.net/taler-typescript-core.git/tree/packages/merchant-backoffice-ui/src/components/SolveMFA.tsx ): <i18n.Translate> You have to wait until{" "} {format(time.t_ms, datetimeFormatForPreferences(preferences))} to send a new code. </i18n.Translate> <i18n.Translate> An SMS to the phone number ending with{" "} <span>{challenge.tan_info}</span> </i18n.Translate> One of the last fixes was done with commit 75bad2dc8d9cf289f709d07e9f7c931cd258454f on January 14 by Sebastian. It seems all OK. So, please, @sebasjm, could you be so nice and explain to us in which version do the fixes appear? What kind of script or action has to be done to apply the source code to the apps? Last but not least, the phrase "You have to wait until [date] to send a new code." is incorrect and should be changed to "You have to wait until [date] to receive a new code." Happy to receive your feedback :) |
|
|
Merchant_Strings_not_internationalised.png (203,128 bytes) |
|
|
Indeed there is a bug on the i18n that I can't find a way to fix yet. The workaround is wrapping dynamic text with <span> <i18n.Translate> You have to wait until{" "} <span>{format(time.t_ms, datetimeFormatForPreferences(preferences))}</span> to receive a new code. </i18n.Translate> This is fixed after 4becda012..c09f5ddc7 I have also removed all other langs from the list execpt EN and DE. |
|
|
> So, please, @sebasjm, could you be so nice and explain to us in which version do the fixes appear? That change you mention is visible on version v1.3.3 |
|
|
commit 7a98e3a1c added back FR and fixed point 3) |
