View Issue Details

IDProjectCategoryView StatusLast Update
0010505Talerdonaupublic2025-10-26 14:12
ReporterFlorian Dold Assigned ToChristian Grothoff  
PrioritynormalSeverityminorReproducibilityhave not tried
Status resolvedResolutionfixed 
Product Version1.0 
Target Version1.2Fixed in Version1.2 
Summary0010505: harness test donau-idempotency results in merchant memory leak
Descriptionexport TALER_HARNESS_VALGRIND=1
taler-harness run-integrationtests donau-idempotency

=> Merchant logs will show valgrind leak check results.
TagsNo tags attached.

Activities

Christian Grothoff

2025-10-23 11:19

manager   ~0026233

That doesn't run valgrind with --leak-check=full, is there a way to do that?

Florian Dold

2025-10-23 18:20

manager   ~0026238

For that, you additionally need

export TALER_HARNESS_VALGRIND_PARAMS='--leak-check=full'

Christian Grothoff

2025-10-26 02:19

manager   ~0026247

Last edited: 2025-10-26 13:19

One remains that is tricky:

==115641== 168 bytes in 3 blocks are definitely lost in loss record 92 of 102
==115641== at 0x4844818: malloc (vg_replace_malloc.c:446)
==115641== by 0x49A29A3: GNUNET_xmalloc_unchecked_ (common_allocation.c:111)
==115641== by 0x49A256F: GNUNET_xmalloc_ (common_allocation.c:59)
==115641== by 0x6764038: DONAU_PQ_result_spec_array_blinded_donation_unit_sig (pq_query_helper.c:805)
==115641== by 0x4A4AC34: DH_PG_lookup_issued_receipts (pg_lookup_issued_receipts.c:41)
==115641== by 0x119140: DH_handler_issue_receipts_post (donau-httpd_batch-issue.c:314)
==115641== by 0x10D7E8: proceed_with_handler (donau-httpd.c:390)
==115641== by 0x10E0BB: handle_mhd_request (donau-httpd.c:635)
==115641== by 0x487F669: call_connection_handler (connection.c:4373)
==115641== by 0x4884077: MHD_connection_handle_idle (connection.c:7335)
==115641== by 0x4886D3B: call_handlers (daemon.c:1320)
==115641== by 0x488BDDD: internal_run_from_select (daemon.c:4578)

The array parser allocates some internal data structure. We cannot free it by calling cleanup on rs as that'd free also the result, which we must return. Will take a bit more care to fix properly.

This one was now fixed, too.

Christian Grothoff

2025-10-26 14:12

manager   ~0026250

ZERO valgrind issues remain.

Issue History

Date Modified Username Field Change
2025-10-17 16:59 Florian Dold New Issue
2025-10-17 16:59 Florian Dold Status new => assigned
2025-10-17 16:59 Florian Dold Assigned To => Florian Dold
2025-10-22 21:36 Christian Grothoff Assigned To Florian Dold => Christian Grothoff
2025-10-23 11:19 Christian Grothoff Note Added: 0026233
2025-10-23 18:20 Florian Dold Note Added: 0026238
2025-10-26 02:19 Christian Grothoff Note Added: 0026247
2025-10-26 13:19 Christian Grothoff Note Edited: 0026247
2025-10-26 14:12 Christian Grothoff Status assigned => resolved
2025-10-26 14:12 Christian Grothoff Resolution open => fixed
2025-10-26 14:12 Christian Grothoff Fixed in Version => 1.2
2025-10-26 14:12 Christian Grothoff Note Added: 0026250
2025-10-26 14:12 Christian Grothoff Product Version => 1.0