View Issue Details

IDProjectCategoryView StatusLast Update
0010142Talermerchant backoffice SPApublic2025-07-05 22:51
ReporterFlorian Dold Assigned Tosebasjm  
PrioritynormalSeverityminorReproducibilityhave not tried
Status resolvedResolutionfixed 
Product Version1.0 
Target Version1.0 stretch goalsFixed in Version1.0 stretch goals 
Summary0010142: merchant SPA does not show or check currency of editable_defaults
DescriptionWhen the default currency of a merchant is changed after a pay-template has been created, the currency in editable_defaults.amount is (as expected) still set to the old default currency.

However, the SPA should save the editable_defaults.amount in the new currency when editing the pay template to have a new template_contract.currency
Tagsux

Activities

Christian Grothoff

2025-06-30 18:07

manager   ~0025382

Plus, the SPA currently shows the template amount in the new currency, even if the old amount is in the DB. That should be fixed.
Note that with the backend being multi-currency capable, the amount should be explicitly editable. If the template uses a default amount in a currency that is no longer supported, the SPA should probably force the user to change/select a new currency/inform the user about the need to fix the currency rather forcefully (when viewing/editing the template).

sebasjm

2025-07-04 22:02

developer   ~0025421

I don't quite understand how to reproduce the problem so how should I reproduce this? step to step will be usefull.
As far as i understood i will:
1) create a template with currency XXX
2) stop merchant, change config to set default currency YYY
3.a) find out what's the currency of the template, try to change it or update the template
3.b) try to use the template, see what happens

I guess this is not very common scenario but it should
a) always use the currency XXX for the already created template
b) not being able to update the template without changing the currency to YYY (if and only if XXX is not longer supported)

Christian Grothoff

2025-07-04 22:07

manager   ~0025422

Well, what happened was that we had the backend configured to the KUDOS default, and then fixed that to CHF (at real merchant) *after* we noticed that the currency was wrong in the template.

Anyway, a related issue is that currently the backend SPA doesn't allow creating templates with non-default currencies, despite the backend actually being multi-currency capable. But we probably should make that a separate less urgent issue. That said, if you instead just allow the user to select the template currency and ONLY allow submitting templates with any of the actually enabled currencies, that'd be ideal. That way, an update would force us right into one of the supported currencies, and we'd address this specific multi-currency issue.

sebasjm

2025-07-05 22:50

developer   ~0025425

When the currency of the template doesn't can't be found in the list of the supported currencies a warning will be shown (screen attached)

If there is more than one currency supported a dropdown will be shown
image.png (15,063 bytes)   
image.png (15,063 bytes)   

sebasjm

2025-07-05 22:51

developer   ~0025426

5dabf9f41..8c1421625

Issue History

Date Modified Username Field Change
2025-06-30 16:39 Florian Dold New Issue
2025-06-30 18:05 Christian Grothoff Assigned To => sebasjm
2025-06-30 18:05 Christian Grothoff Status new => assigned
2025-06-30 18:05 Christian Grothoff Product Version => 1.0
2025-06-30 18:07 Christian Grothoff Note Added: 0025382
2025-06-30 18:07 Christian Grothoff Tag Attached: ux
2025-07-04 22:02 sebasjm Note Added: 0025421
2025-07-04 22:07 Christian Grothoff Note Added: 0025422
2025-07-05 22:50 sebasjm Note Added: 0025425
2025-07-05 22:50 sebasjm File Added: image.png
2025-07-05 22:51 sebasjm Status assigned => resolved
2025-07-05 22:51 sebasjm Resolution open => fixed
2025-07-05 22:51 sebasjm Note Added: 0025426
2025-07-05 22:51 Christian Grothoff Fixed in Version => 1.0 stretch goals