View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0010118 | Taler | merchant backend | public | 2025-06-21 21:18 | 2025-07-11 01:15 |
| Reporter | Christian Grothoff | Assigned To | schanzen | ||
| Priority | urgent | Severity | feature | Reproducibility | N/A |
| Status | resolved | Resolution | fixed | ||
| Platform | i7 | OS | Debian GNU/Linux | OS Version | squeeze |
| Product Version | git (master) | ||||
| Target Version | 1.0 stretch goals | Fixed in Version | 1.0 stretch goals | ||
| Summary | 0010118: merchant backend should have API to list and revoke access tokens | ||||
| Description | We probably also want to extend the /token endpoint to allow the user to give a human-readable name to each token. | ||||
| Tags | No tags attached. | ||||
|
|
We should ideally make sure the API does not differ from the same API of the bank (see 0009644) |
|
|
Work started in dev/schanzen/issue_10118. Descripton and serial columns had to be added to the tokens DB. We deviate from the Bank API because we return the serial as "serial" and not "row_id" row ID seems semantically incorrect. |
|
|
Open tasks: - Test description (it works but needs proper test) - Test pagination Remaining effort: approx 4h |
|
|
API for deletion by serial added, including tests. Pagination tests added. Documentation added. Ready for review. Major point: Name of pagination argument in this API is "serial". In core bank it is "row_id". |
|
|
I just noticed while browsing issues that 0010108 actually requires an API that returns the token itself. Currently, we do NOT return the token in plain text. This is because I modeled it after the Bank API, for which this is also the case. Adding the token field is trivial, if wanted/needed. |
|
|
Eh, the LoginTokenSuccessResponse seems to have the token in plain text, see "access_token" field. What am I not understanding? |
|
|
Now that tokens have a serial that is returned I think all is good. This may be merged whenever. from the branch above and the issue resolved |
|
|
Eh, it appears the branch was already merged? 41e05e290d1c2fbf6edec1699ba97cea10887957 says it IS master and this issue-branch. The "test_merchant_instance_auth.sh" fails for me now in master, which is bad. What happened there? |
|
|
(bumping urgency and target release, as this seems to have broken master). |
|
|
Ups minor last minute regression when filtering expired tokens. Should be fixed in 2da3ea21808c036d8c5889774cb7d5c22d21e522 |
|
|
Works for me now. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2025-06-21 21:18 | Christian Grothoff | New Issue | |
| 2025-06-21 21:18 | Christian Grothoff | Relationship added | related to 0009644 |
| 2025-06-21 21:19 | Christian Grothoff | Note Added: 0025293 | |
| 2025-06-21 21:19 | Christian Grothoff | Status | new => confirmed |
| 2025-06-21 21:19 | Christian Grothoff | Target Version | 1.1 => 1.3 |
| 2025-06-21 22:32 | schanzen | Assigned To | => schanzen |
| 2025-06-21 22:32 | schanzen | Status | confirmed => assigned |
| 2025-06-22 23:16 | schanzen | Note Added: 0025309 | |
| 2025-06-22 23:17 | schanzen | Note Added: 0025310 | |
| 2025-06-23 08:10 | schanzen | Assigned To | schanzen => Christian Grothoff |
| 2025-06-23 08:11 | schanzen | Note Added: 0025315 | |
| 2025-06-24 22:28 | schanzen | Relationship added | related to 0010108 |
| 2025-06-24 22:29 | schanzen | Note Added: 0025351 | |
| 2025-07-03 13:59 | Christian Grothoff | Note Added: 0025398 | |
| 2025-07-03 13:59 | Christian Grothoff | Assigned To | Christian Grothoff => schanzen |
| 2025-07-08 11:53 | schanzen | Status | assigned => feedback |
| 2025-07-08 11:53 | schanzen | Note Added: 0025444 | |
| 2025-07-08 11:54 | schanzen | Assigned To | schanzen => Christian Grothoff |
| 2025-07-09 23:00 | Christian Grothoff | Note Added: 0025477 | |
| 2025-07-09 23:00 | Christian Grothoff | Assigned To | Christian Grothoff => schanzen |
| 2025-07-09 23:00 | Christian Grothoff | Status | feedback => assigned |
| 2025-07-09 23:00 | Christian Grothoff | Priority | normal => urgent |
| 2025-07-09 23:00 | Christian Grothoff | Target Version | 1.3 => 1.0 stretch goals |
| 2025-07-09 23:00 | Christian Grothoff | Note Added: 0025478 | |
| 2025-07-10 08:38 | schanzen | Note Added: 0025481 | |
| 2025-07-11 01:15 | Christian Grothoff | Note Added: 0025491 | |
| 2025-07-11 01:15 | Christian Grothoff | Status | assigned => resolved |
| 2025-07-11 01:15 | Christian Grothoff | Resolution | open => fixed |
| 2025-07-11 01:15 | Christian Grothoff | Fixed in Version | => 1.0 stretch goals |
