View Issue Details

IDProjectCategoryView StatusLast Update
0010070Talerdeployment and operationspublic2025-06-05 13:56
Reporteravalos Assigned ToChristian Grothoff  
PrioritynormalSeverityminorReproducibilityhave not tried
Status assignedResolutionopen 
Target Version1.0 stretch goals 
Summary0010070: TOPS exchange requires ToS download after phone number validation [5h]
DescriptionFor a p2p request, the KYC link first asks to validate the phone number, and then nothing happens.

If you click on the link again, it then asks you to accept the ToS, and it is until then that the transaction completes.
TagsNo tags attached.

Activities

Florian Dold

2025-06-05 03:00

manager   ~0025139

It actually looks like the exchange is simply instating the zero rules here. Doesn't seem like an issue with the TOPS config, but the exchange kyclogic itself.

Maybe the deposit zero rules shouldn't be applied for a wallet account (with a merge reserve payto)?

Reproducer:

$ taler-harness run-integrationtests tops-peer

Note how the exchange logs say this after passing the challenger postal auth:

2025-06-05T02:54:03.855870+0200 taler-exchange-httpd-1598618(Y9AMDSVJ5K1XT9NAG520RJR5PC) INFO lookup_kyc_status_by_token returned 0
2025-06-05T02:54:03.855879+0200 taler-exchange-httpd-1598618(Y9AMDSVJ5K1XT9NAG520RJR5PC) INFO Making applicable zero-measures for accounts under current rules active
{
  "measures": [
    {
      "rule_name": "DEPOSIT-LIMIT-ZERO",
....

Florian Dold

2025-06-05 03:17

manager   ~0025140

Or ... actually, maybe the requirement is okay, and the wallet needs to do a trial merge?

Christian Grothoff

2025-06-05 09:14

manager   ~0025143

We can't exactly remove the zero-DEPOSIT rule here, as the wallet may still need to do a KYC-auth before DEPOSITing into a bank account, right? We validated a phone number, not a bank account.

However, zero-DEPOSIT limits have nothing to do with MERGE/p2p payments, so why would the wallet care about a zero-deposit rule if we're about to do P2P payments? That makes no sense. DEPOSIT rules do *not*apply on MERGE.

Florian Dold

2025-06-05 13:44

manager   ~0025147

Indeed. Thus the wallet should improve the kyc-check handling.

Here's a draft DD for the algorithm: https://docs.taler.net/design-documents/064-kyc-operation-algo.html

Florian Dold

2025-06-05 13:56

manager   ~0025151

Waiting with the implementation until the DD has been reviewed.

Issue History

Date Modified Username Field Change
2025-06-04 16:26 avalos New Issue
2025-06-04 16:51 Christian Grothoff Assigned To => Florian Dold
2025-06-04 16:51 Christian Grothoff Status new => assigned
2025-06-04 23:17 Florian Dold Target Version => 1.0 stretch goals
2025-06-05 02:58 Florian Dold Assigned To Florian Dold => Christian Grothoff
2025-06-05 03:00 Florian Dold Note Added: 0025139
2025-06-05 03:17 Florian Dold Note Added: 0025140
2025-06-05 09:14 Christian Grothoff Note Added: 0025143
2025-06-05 09:14 Christian Grothoff Assigned To Christian Grothoff => Florian Dold
2025-06-05 13:43 Florian Dold Summary TOPS exchange requires ToS download after phone number validation => TOPS exchange requires ToS download after phone number validation [5h]
2025-06-05 13:44 Florian Dold Note Added: 0025147
2025-06-05 13:56 Florian Dold Assigned To Florian Dold => Christian Grothoff
2025-06-05 13:56 Florian Dold Note Added: 0025151