View Issue Details

IDProjectCategoryView StatusLast Update
0010044Talerexchangepublic2025-05-28 19:59
ReporterFlorian Dold Assigned ToFlorian Dold  
PriorityhighSeverityfeatureReproducibilityalways
Status feedbackResolutionreopened 
Target Version1.0 stretch goals 
Summary0010044: exchange should honor Account-Owner-Pub signature when checking Account-Owner-Signature
DescriptionThe wallets now send the additional Account-Owner-Pub header.

Instead of just verifying the signature with the target_pub (from the latest KYC auth transfer) and the latest reserve pub, the exchange should check if the Account-Owner-Pub matches any of the past reserve pubs.

The header should be treated as optional for backwards compatibility.
TagsNo tags attached.

Activities

Christian Grothoff

2025-05-28 18:46

manager   ~0025037

Which endpoint is this? GET /kyc-check/? Did you update the spec?

Christian Grothoff

2025-05-28 19:55

manager   ~0025039

Spec expanded in 2358790a..d74c7cc0

Christian Grothoff

2025-05-28 19:59

manager   ~0025040

Fix committed to master branch.

Christian Grothoff

2025-05-28 19:59

manager   ~0025041

I believe a14ef50b7..ed93a77ce should address this, but didn't test -> feedback.

Related Changesets

exchange: master ed93a77c

2025-05-28 21:49

Christian Grothoff


Details Diff
fix 0010044 Affected Issues
0010044
mod - src/exchange/taler-exchange-httpd_kyc-check.c Diff File
mod - src/exchangedb/exchange_do_lookup_kyc_requirement_by_row.sql Diff File
mod - src/exchangedb/pg_lookup_kyc_requirement_by_row.c Diff File
mod - src/exchangedb/pg_lookup_kyc_requirement_by_row.h Diff File
mod - src/include/taler_crypto_lib.h Diff File
mod - src/include/taler_exchangedb_plugin.h Diff File
mod - src/include/taler_mhd_lib.h Diff File

Issue History

Date Modified Username Field Change
2025-05-28 14:37 Florian Dold New Issue
2025-05-28 14:37 Florian Dold Status new => assigned
2025-05-28 14:37 Florian Dold Assigned To => Christian Grothoff
2025-05-28 18:46 Christian Grothoff Note Added: 0025037
2025-05-28 19:55 Christian Grothoff Note Added: 0025039
2025-05-28 19:59 Christian Grothoff Changeset attached => exchange master ed93a77c
2025-05-28 19:59 Christian Grothoff Note Added: 0025040
2025-05-28 19:59 Christian Grothoff Status assigned => resolved
2025-05-28 19:59 Christian Grothoff Resolution open => fixed
2025-05-28 19:59 Christian Grothoff Note Added: 0025041
2025-05-28 19:59 Christian Grothoff Assigned To Christian Grothoff => Florian Dold
2025-05-28 19:59 Christian Grothoff Status resolved => feedback
2025-05-28 19:59 Christian Grothoff Resolution fixed => reopened