View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0010010 | Taler | libeufin-bank-ui (SPA) | public | 2025-05-25 09:45 | 2025-06-06 17:11 |
| Reporter | Christian Grothoff | Assigned To | Stefan | ||
| Priority | urgent | Severity | text | Reproducibility | always |
| Status | assigned | Resolution | open | ||
| Platform | i7 | OS | Debian GNU/Linux | OS Version | squeeze |
| Product Version | git (master) | ||||
| Target Version | 1.0 stretch goals | ||||
| Summary | 0010010: German translations of English strings chosen at random | ||||
| Description | The German translations do not match with the corresponding English strings in the account dialog of the libeufin-bank SPA. The English strings are now correct, but the German ones are all over the place, and it seems to NOT be a translation issue, but how the translations strings are mapped! | ||||
| Tags | No tags attached. | ||||
| Attached Files | |||||
|
|
Stefan explains that this is because Sebastian completely changed the English text of certain IDs without also changing the IDs. That's bad practice. If you (significantly, non-typo-issues) change the English, you MUST use a new ID. Also avoid re-using IDs unless the English is absolutely clearly and always the same (say a "Confirm" or "Cancel" button label). |
|
|
No worries, please. The translation of the Taler Bank SPA is on my priority list and will be finished soon. |
|
|
There is no way i edited the english text instead of the key, if you find a commit please let me know |
|
|
Duration: About 16-24 hours Deadline / delivery date: This Friday (June 6) Some strings in English need to be rectified in the source code (sorry, Sebastian, there are way more to come): Source string in Weblate --> my recommendation - Only "IBAN" target are supported --> Only IBAN numbers are accepted - Missing "amount" parameter to specify the amount to be transferred --> Please enter an amount to be transferred [but which amount? Is the "amount" parameter a preset for wire transfers for withdrawal transactions?] - Making a wire transfer --> The wire transfer will be processed - Rnvalid --> Invalid - Recipient (https://weblate.taler.net/translate/gnu-taler/taler-bank-spa/en/?checksum=436dd0caec8a025d) --> Recipient's account [This term means the recipient's IBAN account, right?] - A special URI that specifies the amount to be transferred and the destination account. --> A special URI that specifies the amount to be transferred to the destination account. - Only "x-taler-bank" target are supported --> Only "x-taler-bank" targets are supported - Only "IBAN" target are supported --> Only "IBAN" targets are supported - Server replied with invalid phone or email. --> The Server replied that phone or email addresses are invalid. - Balance is not enough --> The balance is insufficient |
|
|
I double-checked all existing 165 English and German strings. There were some mapping issues, some little typos/need for stylistic improvement, but not yet the big troubles leading to bad German. Presumably, those haven't been translated yet - or the language strings were simply not applied for the component by an update on the source code. Will further investigate and finish with translations. |
|
|
We are at 43%, still 255 strings to translate for German. |
|
|
By reviewing one of my recent commits https://git.taler.net/taler-typescript-core.git/commit/?id=ba0950da2b99fdad1f84a10b09c0fe96e77121fa I was made aware that it was neither Sebastian's fault nor my fault that a mismapping of strings in the Taler Bank SPA occurred. @Sebastian is right, this did not happen on behalf of one of his commits. It is Weblate that fucks up the mapping of some strings. Example: msgid "The operation failed." msgstr "Die Überweisung auf das Konto des Zahlungsdiensts wurde durch Fremdeinwirkung abgebrochen, Ihr Guthaben ist davon in keiner Weise betroffen." I translated a string which was swapped afterwards and mapped my translation to another English string! Sure, Weblate informed me with a warning message "The string has been changed meanwhile." but saved my translation anyways. WTF! Workaround: I keep on translating and checking effects in the Bank SPA app while reviewing each of the commits from Weblate to git. Problem: I am running out of time now and need to know whether this task should be completed urgently or whether we can resume in two weeks. As a third way, I could propose to do the translation work during my vacation, but this is on my good-will basis only and I do not want to get stressed nor called on the phone or obtain emails. And, last but not least, I do not want to see here on Mantis any accusations of team members anymore. Please, @Christian, decide what to do in Mantis directly. |
|
|
Well, if Weblate cannot keep the string mappings straight, we need to obsolete it and use something else, probably just go back to manually editing .po files. Because software that randomizes our translations isn't useful. |
|
|
https://github.com/mozilla/pontoon/ might be an alternative to weblate. |
|
|
We are meanwhile at 52%, still 215 strings to translate for German. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2025-05-25 09:45 | Christian Grothoff | New Issue | |
| 2025-05-25 09:45 | Christian Grothoff | Status | new => assigned |
| 2025-05-25 09:45 | Christian Grothoff | Assigned To | => sebasjm |
| 2025-05-25 09:45 | Christian Grothoff | File Added: badgerman.png | |
| 2025-05-25 14:27 | Christian Grothoff | Note Added: 0024989 | |
| 2025-05-25 14:27 | Christian Grothoff | Assigned To | sebasjm => Stefan |
| 2025-05-26 08:22 | Stefan | Note Added: 0024997 | |
| 2025-05-28 15:19 | sebasjm | Note Added: 0025035 | |
| 2025-05-29 14:45 | Christian Grothoff | Category | mailbox => libeufin-bank-ui (SPA) |
| 2025-06-03 11:46 | Stefan | Note Added: 0025093 | |
| 2025-06-03 18:13 | Stefan | Note Edited: 0025093 | |
| 2025-06-03 18:18 | Stefan | Note Added: 0025108 | |
| 2025-06-05 11:49 | Stefan | Note Added: 0025144 | |
| 2025-06-06 13:52 | Stefan | Note Added: 0025174 | |
| 2025-06-06 15:31 | root | Note Added: 0025175 | |
| 2025-06-06 15:40 | Christian Grothoff | Note Added: 0025176 | |
| 2025-06-06 17:11 | Stefan | Note Added: 0025178 |
