View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0006158 | GNUnet | util library | public | 2020-04-03 14:18 | 2020-07-09 09:17 |
Reporter | fefe | Assigned To | Christian Grothoff | ||
Priority | normal | Severity | minor | Reproducibility | always |
Status | closed | Resolution | fixed | ||
Product Version | Git master | ||||
Target Version | 0.13.0 | Fixed in Version | 0.13.0 | ||
Summary | 0006158: GNUNET_STRINGS_check_filename uses the wrong stat | ||||
Description | One of the checks (specified as an argument to the function) is to check whether the filename refers to a symbolic link. Here is the code: 1186 if (0 != (checks & GNUNET_STRINGS_CHECK_IS_LINK)) 1187 if (! S_ISLNK (st.st_mode)) 1188 return GNUNET_NO; This only works if we use lstat(2). If we used stat(2) then symbolic links are followed and the returned struct refers to the file they pointed to, not the link. So S_ISLNK can never be set when we used stat instead of lstat. 1175 if (0 != stat (filename, &st)) This needs to be lstat instead. | ||||
Tags | No tags attached. | ||||
|
Agreed, I'm just a bit surprised we even call check_filename from Taler. Anyway, fixed in bc19a7509..bc01117ce. And I did try to warn you that AFAIK nobody every carefully looked at libgnunetutil. |
|
0.13.0 released |
Date Modified | Username | Field | Change |
---|---|---|---|
2020-04-03 14:18 | fefe | New Issue | |
2020-04-03 18:48 | Christian Grothoff | Note Added: 0015510 | |
2020-04-03 18:48 | Christian Grothoff | Assigned To | => Christian Grothoff |
2020-04-03 18:48 | Christian Grothoff | Status | new => resolved |
2020-04-03 18:48 | Christian Grothoff | Resolution | open => fixed |
2020-04-03 18:48 | Christian Grothoff | Fixed in Version | => 0.12.2 |
2020-04-03 18:48 | Christian Grothoff | Target Version | => 0.12.2 |
2020-04-23 10:45 | schanzen | Fixed in Version | 0.12.2 => 0.13.0 |
2020-04-23 10:47 | schanzen | Target Version | 0.12.2 => 0.13.0 |
2020-06-01 00:49 |
|
Issue cloned: 0006317 | |
2020-06-01 00:52 |
|
Issue cloned: 0006349 | |
2020-07-09 09:17 | schanzen | Note Added: 0016429 | |
2020-07-09 09:17 | schanzen | Status | resolved => closed |