View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0009966 | Taler | wallet-core | public | 2025-05-15 13:49 | 2025-08-31 17:09 |
| Reporter | Bohdan | Assigned To | Florian Dold | Resolution deadline | |
| Implementer | Reviewer | ||||
| Release signed by | Deployed by | ||||
| Verifier | Communicator | ||||
| Data protection authority notification required | No | ||||
| CSIRT notification required | No | ||||
| Estimated effort (hours) | Actual effort (hours) | 0 | |||
| Fast-track | No | ||||
| Work package | none | ||||
| Priority | normal | Severity | minor | Reproducibility | random |
| Status | closed | Resolution | fixed | ||
| Product Version | 1.0 | ||||
| Target Version | 1.0 stretch goals | Fixed in Version | 1.0 stretch goals | ||
| Summary | 0009966: Apparently wallet core can try to claim the order which was already paid [3h] | ||||
| Description | I believe the issue comes from the fact that I have tried to claim the order several times because of errors, and when I finally succeeded and paid it, the order ID that was in the DB to be retried with the same order id has not been removed from the retry state and still asks to claim it... every 5 minutes I also believe this could be a root of the problem if the user tries to make a refund for such an order, and it will fail... | ||||
| Tags | vivy | ||||
| Is this reproducible? | |
| I believe yes... especially with dev setup of wallet core To reproduce it myself, I need to make a faulty merchant than do a couple of requests where merchant will return error, or rather to fully reproduce the exchange must return error that merchant can't get the money deposited(the problem of iban and x-taler-bank), and then try to pay it one more time... | |
| Strong feeling that same order id can be in list of failed and to be retried, and in the same time to be actually paid, and not removed from the other list | |
| Still could not reproduce it, but the following commit could in theory fix it (not yet available in published wallets). If the problem persists, please re-report with instructions on how to reproduce. commit 6df6fd6ee7c9835956f861354cfd90b789a79df1 (HEAD -> master) Author: Florian Dold <florian@dold.me> Date: Sat Aug 2 11:44:12 2025 +0200 wallet-core: fix matching of existing purchase transactions Should fix https://bugs.taler.net/9966 | |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2025-05-15 13:49 | Bohdan | New Issue | |
| 2025-05-15 14:35 | Florian Dold | Note Added: 0024919 | |
| 2025-05-15 15:16 | Bohdan | Note Added: 0024921 | |
| 2025-05-15 15:17 | Bohdan | Note Added: 0024922 | |
| 2025-05-15 19:56 | Christian Grothoff | Assigned To | => Florian Dold |
| 2025-05-15 19:56 | Christian Grothoff | Status | new => assigned |
| 2025-05-19 17:32 | Florian Dold | Product Version | 1.0 => 1.1 |
| 2025-05-19 17:32 | Florian Dold | Product Version | 1.1 => |
| 2025-05-19 17:32 | Florian Dold | Target Version | => 1.1 |
| 2025-06-05 11:58 | Florian Dold | Summary | Apparently wallet core can try to claim the order which was already paid => Apparently wallet core can try to claim the order which was already paid [3h] |
| 2025-07-30 09:29 | Christian Grothoff | Tag Attached: vivy | |
| 2025-08-02 09:45 | Florian Dold | Note Added: 0025609 | |
| 2025-08-02 09:46 | Florian Dold | Status | assigned => informing |
| 2025-08-02 09:46 | Florian Dold | Resolution | open => fixed |
| 2025-08-04 20:24 | Christian Grothoff | Product Version | => 1.0 |
| 2025-08-04 20:24 | Christian Grothoff | Fixed in Version | => 1.0 stretch goals |
| 2025-08-04 20:24 | Christian Grothoff | Target Version | 1.1 => 1.0 stretch goals |
| 2025-08-31 17:09 | Christian Grothoff | Status | informing => closed |